Any chance we could use drawLayout with Dialogs in...

# compose

[Kazemihabib1996]

Any chance we could use drawLayout with Dialogs in future?
I'm trying to implement Overshoot animation with Dialogs

Transition(
            definition = transDef,
            initState = AnimState.StartScale,
            toState = AnimState.EndScale
        ) { state ->
            Box(
                modifier = Modifier.drawLayer(
                    scaleX = state[scale],
                    scaleY = state[scale]
                )
            ) {
                Dialog(onCloseRequest = onDismiss) {
                ...

This doesn't work and I hope this works in future 🙂

And using

Dialog(onCloseRequest = onDismiss) {
                    Surface(
                        shape = MaterialTheme.shapes.medium, modifier = Modifier.drawLayer(
                            scaleX = state[scale],
                            scaleY = state[scale]
                        )
                    ) {
                    ...

Just overshoots inside of the dialog not the dialog it self.

[Kazemihabib1996]

device-2020-04-30-170657.mp4

[Kazemihabib1996]

I found a kind of solution by wrapping the content inside bigger transparent parent. so it just like the dialog it self scales up and down when animation.

[Mihai Popa]

Could you please file a bug with the code not working?

[Kazemihabib1996]

OK

[Kazemihabib1996]

@Mihai Popa
I'm not sure if this can be considered a bug
Wrapping a Dialog with Box with drawLayer modifier not works,
and the modifier should be added to Dialog content.
But it will just scale, rotate and ... the content not dialog itself.

[Kazemihabib1996]

@Mihai Popa
Also there is another problem with dialog that I don't know it was on purpose or bug.
The source of AlertDialog copies the properties of the MaterialTheme (new added property shapes is forgotten)
but Dialog do not do that and uses the default lightTheme.
IMHO this should be done inside Dialog instead of AlertDialog

[Andrey Kulikov]

this sounds like a bug, could you please file it?

[Kazemihabib1996]

@Andrey Kulikov of course, you mean both of them?

[Kazemihabib1996]

or just this one
https://kotlinlang.slack.com/archives/CJLTWPH7S/p1588264434072600?thread_ts=1588250115.066300&cid=CJLTWPH7S

[Andrey Kulikov]

worth filling both, thought I am not sure we can fix the first one. the second one is a bug for sure

[Kazemihabib1996]

Done