Channels
#compose
Title
# compose
g
Gabriel Feo
04/29/2020, 11:25 PMJust out of curiosity, is it a convention from somewhere to name constants in UpperCamelCase? This is from
Constraints2z
Zach Klippenstein (he/him) [MOD]
04/29/2020, 11:28 PMI believe the Kotlin style guide recommends either this style or SCREAMING_SNAKE_CASE, but the Android-specific kotlin style guide narrows that down to just screaming snake.
g
Gabriel Feo
04/29/2020, 11:29 PMLol that name pretty much describes my discomfort with naming constants
a
Adam Powell
04/29/2020, 11:59 PMYeah we've been doing this across compose and will likely update the Android kotlin style guide to match. It doesn't make much sense to have SNAKE_CASE for some "constants" when you also have
objectobject👍 3
Or a top level
valobjectm
mzgreen
04/30/2020, 5:02 AMWill we get classes named like Constraints2 at launch? Or do you plan to clean this up in the future?
a
Adam Powell
04/30/2020, 5:20 AMNah those will replace the old ones and get renamed. The nice thing about pre-alpha releases is we can break APIs with abandon 😁
😂 1
Mostly we're trying to use the kotlin deprecated/replaceWith facilities to make keeping up with the changes easier. Our first few releases were pretty rough so we're trying to do better gradual migrations
But since we do our own CI with warnings as errors, if we deprecate we have to also migrate our whole codebase at the same time. Good and realistic incentive but it takes a little time
m
mzgreen
04/30/2020, 6:19 AMYeah makes sense, thank you 🙂