Hey I'm having some difficulties using ConstraintL...

# compose

[caelum19]

Hey I'm having some difficulties using ConstraintLayout. I expect this blue box to be at the bottom, am I doing it wrong somehow?

Untitled

[caelum19]

[Gabriel Feo]

Trying to sort out some issues with ConstraintLayout too, but tested something similar to what you wrote, it's working

[caelum19]

Oh, of course, it can't position its children inside itself if its the same size of the children! good spot thanks 😄

[caelum19]

What issue are you having?

[Gabriel Feo]

Constraints weren't being applied... Just found out I mispelled the tag on the modifier lol

[caelum19]

haha I was doing that a few times too

[caelum19]

What do you think about having the ConstraintLayout body inside of the body where constraint sets are defined so that the tags can be referenced as variables?

[Gabriel Feo]

I don't think we'd need to mix those two, but I agree we should be defining the tag names in a common scope, to avoid these mistakes

[Gabriel Feo]

I wish there was some overlap between ConstraintSetBuilderScope.tag and Modifier.tag though, so that we declare it once and just use it on the ConstraintSet and on the children

[caelum19]

hmm but I guess it could be confusing if the common scope were common to more than one constraint layout?

[Gabriel Feo]

It definitely could

[Gabriel Feo]

But then again, if there are two ConstraintLayouts in the same scope, one of them (or both) should probably be extracted to a separate function

[caelum19]

what sort of overlap do you have in mind? Like AS just looking at the strings or?

[caelum19]

maybe that is the only way to bring safety without having people write not so elegant code

[Gabriel Feo]

Thinking of a common type, which implements both Modifier and ConstrainedLayoutReference

[Gabriel Feo]

But I'm getting ahead of myself here, don't know much of the internals, that's probably not the best design choice

[caelum19]

Oh so that you wouldn't need to wrap with Modifier.tag() ? I like the Modifier.x().y(), it indents nicer than +s

[caelum19]

but yeah, we can hold off any prs for now 😛 just interesting to talk about

[Gabriel Feo]

It is 🙃 I look forward to contributing, I'm trying to get up to speed