The `drawLayer` modifier is real nice!
<https://gi...
# composez
Zach Klippenstein (he/him) [MOD]
03/27/2020, 4:36 PMThe
drawLayer❤️ 28
😮 21
✨ 9
👍 11
r
romainguy
03/27/2020, 4:38 PMCan you say more about this comment:
romainguy
03/27/2020, 4:38 PM“// Animating the alpha just look janky.”
z
Zach Klippenstein (he/him) [MOD]
03/27/2020, 4:39 PMSorry, it works fine – I meant it just looks weird to have the alpha bouncing around. It’s not obvious that it’s animating, it just looks strange.
r
romainguy
03/27/2020, 4:40 PMOk thanks! Just wanted to make sure it wasn’t an issue on our side 🙂
z
Zach Klippenstein (he/him) [MOD]
03/27/2020, 4:46 PMNope, alpha works as expected. However, there is an issue with x/y rotation when the scale is too big: when the rotation is around 90º, lots of weird clipping or something starts to happen. This looks weird for other reasons (views are basically unreadable), so I don’t know why an app would try to do this in production, but I can file a bug.
r
romainguy
03/27/2020, 5:09 PMI am not surprised by this
romainguy
03/27/2020, 5:10 PMThese are fake 3D rotations and I can definitely think of a few ways that they would catastrophically break down at such acute angles in Skia
romainguy
03/27/2020, 5:10 PMPlease file a bug if you want but it’s not Compose specific
romainguy
03/27/2020, 5:10 PMI can forward this to one of the graphics engineers
romainguy
03/27/2020, 5:10 PMWhat version of Android is this on?
z
Zach Klippenstein (he/him) [MOD]
03/27/2020, 5:31 PMAndroid 10, March 5 2020 security patch, build QQ2A.200305.002
Zach Klippenstein (he/him) [MOD]
03/27/2020, 5:31 PMI'm not worried about it, doesn't seem like it would be an issue in real apps
r
romainguy
03/27/2020, 5:44 PMThanks
romainguy
03/27/2020, 5:44 PMYeah but still awkward
k
Klaas Kabini
03/27/2020, 5:50 PM@Zach Klippenstein (he/him) [MOD] This is a pretty interesting demonstration of the
drawLayer👍 2
l
louiscad
03/27/2020, 6:09 PMI totally see that being used in an app onboarding
a
Adam Powell
03/27/2020, 8:53 PMsince someone asked on twitter, no, this doesn't support transforming the input events - yet. 🙂 We were just discussing unifying transformations for layout/drawing/input earlier this week
👍 1
Adam Powell
03/27/2020, 8:54 PMmight end up being a slightly different modifier API that uses
drawLayerAdam Powell
03/27/2020, 8:54 PMnot sure yet
r
romainguy
03/27/2020, 9:42 PMWe filed a bug internally, the Skia team will investigate. Thanks for the repro case!
🙏 1
v
Val Salamakha
03/28/2020, 1:37 AMZack, what kind of compose do you use? I cannot access default buttons as Add and others (dev-07) - only Favourite, Menu and Close available.
z
Zach Klippenstein (he/him) [MOD]
03/28/2020, 1:39 AMYou need the material icons dependency as well:
androidx.ui:ui-material-icons-extended:${versions.compose}Zach Klippenstein (he/him) [MOD]
03/28/2020, 2:00 AM@romainguy I just noticed that the shadow under the FAB doesn’t rotate around the Z axis with the rest of the views – it’s always “below” the button relative to the screen, at every angle. I’m guessing that’s because the shadow has its own layer?
r
romainguy
03/28/2020, 2:01 AMyep
👍 1
z
Zach Klippenstein (he/him) [MOD]
03/28/2020, 2:01 AMReally obvious here
😮 1
v
Val Salamakha
03/28/2020, 3:12 AMThanks, Zach
z
Zach Klippenstein (he/him) [MOD]
03/30/2020, 4:31 PMIt's a bit of a contrived use case, but this is the demo I wanted to write when I first saw this composable 😂 made me think of the new layout inspector's 3D view
https://kotlinlang.slack.com/archives/C0BJ0GTE2/p1585585754055600
r
romainguy
04/01/2020, 3:59 PMThe bug is confirmed fixed in Android R btw
🙏 1
b
Bernardo Ferrari
04/01/2020, 8:10 PMcan’t we have skia updatable via project mainline to avoid issues like this in the future?
r
romainguy
04/01/2020, 8:52 PMIt’s in the works
😍 4
b
Bernardo Ferrari
04/01/2020, 10:26 PMAndroid S.. S of Skia.. lol, can’t wait! haha
(sidenote: unfortunately my device won’t receive it, but hopefully until then Samsung will be giving more than 2 major updates)