if I remove the comment, sends the error cc <@UJBKXD0HH>

# compose

[Mariano Zorrilla]

if I remove the comment, sends the error cc @Adam Powell

recycledlist.kt

[Mariano Zorrilla]

I'd tried with "state" directly, with a fun @Composable, etc and nothing, and there's no info online

[Adam Powell]

You are indeed calling a composable function from a non-composable function as the error suggests 🙂

[Mariano Zorrilla]

how do I add then a new item to my list so my AdapterList has more values?

[Mariano Zorrilla]

I'm clueless, sorry

[Adam Powell]

It's ok 🙂 lots of new stuff in play here

[Adam Powell]

There are two things you need to accomplish: add more data and make sure compose knows about it to update

[Mariano Zorrilla]

I know 😋 trying to get lot of info to make a Meetup, help folks over SoF and Medium and trying to investigate A LOT

[Adam Powell]

You've declared ListCounter to be @Model which will notify compose if any of its vars change, but you're not changing one of its vars, you're changing a mutable list contained therein

[Adam Powell]

You'll want to remove @Composable from your emitter - it doesn't need to be special, and you don't want to wrap the change in state {} - that's for declaring a tracked MutableState<T> and `remember {}`ing it at that point in the composition. You already have your state object and don't need to create another.

[Adam Powell]

You have two ways to go: you can make the mutable list changes visible to compose, or you can use immutable lists and change the model class var that is already tracked by compose

[Mariano Zorrilla]

thanks! and how to I make my mutable list visible to compose?

[Adam Powell]

You can use modelListOf instead of mutableListOf

[Adam Powell]

If you go that direction you should make the list a val rather than a var

[Mariano Zorrilla]

life saver! Thanks

[Mariano Zorrilla]

this March 18th I'll do a talk about Jetpack Compose in Argentina and was planning to host one in San Francisco (when I get sure there's not health issues) for Jetpack Compose, Flutter and Swift UI that I think it will be awesome to compare all new declarative UIs

[Mariano Zorrilla]

I'll add you to the slides 😋

[Mariano Zorrilla]

is there any way to get the AdapterList current index?

[Zach Klippenstein (he/him) [MOD]]

Call withIndex() on your list before passing it to AdapterList.

[Mariano Zorrilla]

Thank you so much! I also noticed adding items to modelList is ok but removing creates an out of bounds exception

[Mariano Zorrilla]

withIndex().toList() over AdapterList works as well for index 🙂

[Adam Powell]

please file a bug for the removal thing so we can investigate

[Adam Powell]

you might also find it useful to experiment with the kotlinx.collections.immutable library's PersistentList and assign the new immutable lists to a model field or State<T> - we use those collections internally in compose so it's not going to add any more overhead to your apk size than is already there

[Mariano Zorrilla]

Thanks! I'm trying to "break it" 😉 to check all I can do with AdapterList

[Mariano Zorrilla]

I'll check that and file the bug

[Adam Powell]

AdapterList is a very early prototype of the API shape and some approaches to the internal composition and layout model for virtualized layouts like this - I'm sure there are many ways to break it at the moment 🙂

[Ryan Mentley]

If you did file that bug, please send it to me - I am aware of it from a StackOverflow post but hadn't filed an issue with a repro case yet

[Ryan Mentley]

If you haven't, I'll file it soon

[Ryan Mentley]

the removal bug is now fixed: https://android-review.googlesource.com/c/platform/frameworks/support/+/1282253

[Mariano Zorrilla]

Amazing! Thanks!