https://kotlinlang.org logo
#compose
Title
# compose
i

Ian Warwick

03/05/2020, 4:39 PM
Hey composers, what is the alternative to
DrawShape
now?
Maybe Surface 🤔
Copy code
Surface(modifier = LayoutWidth(AlertDialogWidth), shape = AlertDialogShape)
z

Zach Klippenstein (he/him) [MOD]

03/05/2020, 4:44 PM
Surface
is material-specific. I think
Box
is probably the replacement: it takes a
shape
parameter, which it forwards to the
DrawBorder
and
DrawBackground
modifiers.
👍 1
i

Ian Warwick

03/05/2020, 4:44 PM
cool cheers guys!
❤️ 1
c

codeslubber

03/05/2020, 4:59 PM
Would it be that hard to put something in the release notes??
z

Zach Klippenstein (he/him) [MOD]

03/05/2020, 5:27 PM
@codeslubber The release notes always link to the commit list if you really want to check. Compose is still pre-alpha, they’re not prioritizing comprehensive documentation yet. If you’re not willing to deal with sharp edges like this occasionally, just don’t use the library until it’s released 🙂
l

Leland Richardson [G]

03/05/2020, 5:44 PM
the release notes are automated from commit messages right now. As a result, the answer is basically “yes, if the author remembers!“. I think adding these types of things in the release notes would be great. i’ll mention it to folks whenever i see an oppurtunity. hopefully we will get better at this over time
c

codeslubber

03/05/2020, 5:52 PM
@Zach Klippenstein (he/him) [MOD] thanks that was SUPER helpful..
👍 1
@Leland Richardson [G] thanks, I am just saying if something is going away, even if there were a tiny list x -> y that would save a lot of effort. The whole point of releasing early is to get feedback.
l

Leland Richardson [G]

03/05/2020, 5:56 PM
yep, i totally agree
we just need to get better about remembering to put them in the release notes! Compose being early means we are going to be changing a lot of things, but that doesn’t mean we can’t type up really quick migration hints
👍🏻 2
c

codeslubber

03/05/2020, 6:32 PM
Change away, not complaining about that at all. I think you guys are exhibiting some of the best refine in the open tactics I have seen from a major team, which is great.
r

Ryan Mentley

03/05/2020, 9:51 PM
as a small addition, they're semi-automated, so if you see a commit that should've had a release note, and you poke us, we can add it into the doc manually later
(but we're trying to do it correctly the first time)
2
3 Views