aryk
03/04/2020, 9:18 PMindent
parameter? Can't we just add a left offset with padding?
@Composable
fun Divider(
modifier: Modifier = Modifier.None,
color: Color = MaterialTheme.colors().surface,
height: Dp = 1.dp,
indent: Dp = 0.dp
): Unit
Leland Richardson [G]
03/04/2020, 9:41 PMLayoutPadding(left=…)
, but in this case Divider
is a specific component in the Material spec that is being implemented, where indent
is specifically a parameter that the spec allows you to change, as such, we consider it as “part of the component itself”.
However, we are going to rename it to startIndent
so that will be a little bit more clear that it is asymmetric