As of at least dev04 (haven’t tried earlier), it l...

# compose

[Zach Klippenstein (he/him) [MOD]]

As of at least dev04 (haven’t tried earlier), it looks like Clip isn’t doing anything. I can implement DrawModifier and manually clip the canvas before drawing the children, and that works, but Clip doesn’t seem to have any effect whatsoever. Is this a known issue?

[Andrey Kulikov]

Clip definitely works, at least for our cases. we clip Surfaces and Buttons with them. it is possible it works not as you expect in the moment in combination with some LayoutModifiers, which is expected. could you please share your code?

[Zach Klippenstein (he/him) [MOD]]

Yea, I expect I am probably using it wrong.

This code works: https://github.com/square/workflow/blob/dc67f5a8332bd88642e5a10c00a6f6bf04ba6557/kotlin/samples/containers/compose/src/main/java/com/squareup/sample/composecontainer/pictureframe/PictureFrame.kt#L150

This code doesn’t: https://github.com/square/workflow/blob/47a76b103e995a3baa2cf3c5b4ad35c76d361b8e/kotlin/samples/containers/compose/src/main/java/com/squareup/sample/composecontainer/pictureframe/PictureFrame.kt#L54-L59

[Zach Klippenstein (he/him) [MOD]]

(here’s the diff between the two: https://github.com/square/workflow/compare/dc67f5a8...zachklipp/compose-nesting-bad-clip?expand=1)

[Andrey Kulikov]

Hey. I figured out why it works like this for you.
Right now Clip behaves similarly to Draw component, which means uses the parent layout size. To debug the issue I added
DrawShape(shape = RoundedCornerShape(thickness), color = Color.Cyan)
on the same level as Clip in your code and it clips, but using the size of Center component, not Box, that why the effect is not visible. To fix this right now you can wrap your Clip component inside "Wrap" layout, and this will do the trick. In the future we expect Clip will be done as a modifier and you will do something like modifier = Clip(RoundedCornerShape(thickness)) + PictureFrameModifier(thickness, colors, cache), but not right now

[Zach Klippenstein (he/him) [MOD]]

Awesome, thanks for the investigation + explanation!