Hi :wave: We’re struggling with the Kotlin upgrade...

# ktlint

[ralf]

Hi 👋 We’re struggling with the Kotlin upgrade since version 0.36.0. KtLint is the only blocker that’s left for us to upgrade Kotlin to 1.4. We used to have an indent of 2 spaces with a continuation indent of 4 spaces. KtLint doesn’t support the continuation indent anymore, so we changed it to 2 spaces as well to make our life easier.

Nonetheless, we still run into quite a few indent issues. I’ve tested the latest snapshot 0.40.0 and filed three tickets:
https://github.com/pinterest/ktlint/issues/963
https://github.com/pinterest/ktlint/issues/964
https://github.com/pinterest/ktlint/issues/965

There are quite a few open indentation issues and they might be duplicates. I also saw some fixes in 0.40.0. Is there a timeline when to expect a new release? Thanks!

[jlleitschuh]

I'm not a maintainers of Ktlint, I'm a maintainer of Ktlint-Gradle, but a relevant note, contributing PRs to fix issues, along with solid unit test coverage, is usually appreciated

[ralf]

Of course, but I rather ask if these are duplicates or WIP items first. And like I said, the last release is 2 months old and a few fixes have been merged since then. Maintaining an internal revision isn’t a lot of fun.

[Sha Sha Chu]

hi @ralf! i don’t have a specific timeline, but i’d guess within the next couple of weeks. the 3 of us who are maintainers have all been pretty busy with our day jobs, but @romtsn is planning on doing a lot of fixes for the indentation rule

[Sha Sha Chu]

thanks for your patience

[ralf]

No worries and thanks for the quick reply. If you plan more work around the indentation rule, would you like to receive contributions or are the failing examples good enough? I didn’t dig into it myself, yet.

[jlleitschuh]

Makes sense

[ralf]

Oh wow, @romtsn is killing all tickets one by one. Very much appreciated 🙏

[romtsn]

all the props to @t-kameyama I am just merging so far 😅

[romtsn]

still for you guys at square to have fully functional linter we need to make a few more enhancements, like node-specific continuation indents and so on 🙂