Thank you, actually I have another question. We us...

# kvision

[Tomas Kormanak]

Thank you, actually I have another question. We use navbar but we have an issue with closing menus. When I click on a menu I would expect other opened menu to close, but the stay open.

[Robert Jaros]

Use collapseOnClick = true

[Tomas Kormanak]

I think there is a bug in collapseOnClick option, it seems it uses different css selectors than dropdowns use.

if (collapseOnClick) {
            setInternalEventListener<Navbar> {
                click = {
                    val target = jQuery(it.target)
                    if (target.`is`("a.nav-item.nav-link")) {
                        val navbar = target.parents("nav.navbar").first()
                        val toggler = navbar.children("button.navbar-toggler")
                        val collapse = navbar.children("div.navbar-collapse")
                        if (collapse.`is`(".show")) toggler.click()
                    }
                }
            }
        }

but dropdown has class dropdown-toggle

[Robert Jaros]

do you set forNavbar = true property when using DropDown inside NavBar?

[Tomas Kormanak]

I do

[Robert Jaros]

I'll check this out later today

[Robert Jaros]

A question - are we talking about collapsed navbar menu? or about a dropdown component put inside a navbar?

[Tomas Kormanak]

a dropdown inside navbar

[Robert Jaros]

I see. That's why it doesn't work. The collapseOnClick property is for navbar menu.

[Robert Jaros]

The dropdown component is a different case.

[Robert Jaros]

It's not really KVision issue, it's a Bootstrap dropdown issue.
https://stackoverflow.com/questions/39812115/how-to-close-bootstrap-dropdown-menu-on-button-click

[Robert Jaros]

But we can definitely fix this with a similar approach

[Robert Jaros]

Adding collapseOnClick property for a DropDown component

[Robert Jaros]

Please fill an issue for this as well.

[Tomas Kormanak]

Just to make sure. The issue is that I have multiple dropdowns in navbar and when I open one I would like to close others

[Robert Jaros]

So you just want a dropdown menu. I will think what can be done about this.

[Tomas Kormanak]

We already use it

[Robert Jaros]

I think it should be possible but it will take some hacking ;-)

[Tomas Kormanak]

🙂

[Robert Jaros]

Right now I can't even propose a workaround because I have stopPropagation on the click event in the DropDownButton.

[Tomas Kormanak]

I know.

[Robert Jaros]

But I'll try to fix this during the weekend.

[Tomas Kormanak]

Anyway, could you give me quick brief how to setup KVision for contributing?

[Robert Jaros]

Have you seen https://github.com/rjaros/kvision/blob/master/CONTRIBUTING.md ?

[Tomas Kormanak]

ahh, sorry I missed it.

[Robert Jaros]

It should work the way described, at least until you try to edit npm resources

[Robert Jaros]

If you will need to modify css files let me know - I'll try to describe how to do it (at least how I do it ;-)

[Tomas Kormanak]

Thank you I'll try it