https://kotlinlang.org logo
n

Nikky

06/08/2021, 7:47 AM
the only thing left is that idea sync is now broken in the sample-groovy from what i can tell it calls
bootstrap
for the buildSrc., succeeds and then calls it again and that somehow happens in a context where the config holder has no configs i tried just not removing them , intentionally leaking i guess.. but that did not fix it either.. so i think it executes it in a seperate classpath
l

louiscad

06/08/2021, 9:29 AM
buildSrc is also a standalone Gradle project, and IDEA sync runs it independently as well.
n

Nikky

06/08/2021, 10:16 AM
what i am confused about.. that happens after all of them should have ran their reset code.. so i would expect it to fail i have to spend some more time debugging it
l

louiscad

06/08/2021, 10:17 AM
refreshVersions does stuff to avoid the standalone buildSrc build to fail. I made it write some files in build dir
n

Nikky

06/08/2021, 11:11 AM
i debugged a bit and found where i made a mistake, its not fixed.. i tested a bit and all samples currently do the idea sync properly
i'd say the PR is ready for review.. and i am sorry for how huge it turned
l

louiscad

06/08/2021, 11:20 AM
Can you comment in the PR, then? Splitting the info between Slack and PR comments makes it a bit harder to manage when I have the time to get back to it and focus on the review.
n

Nikky

06/08/2021, 11:33 AM
i will append this to the PR description and keep it updated