refreshVersions might not work out of the box with...
# refreshversions
n
refreshVersions might not work out of the box with maven on
gcs://
urls (google cloud storage)
l
It doesn't. We have someone interested in adding support for AWS S3. We are equally if not more interested in adding support for gcs backed repos
n
i would be very interested because usage for work
l
I think that all we need is info on how to reach Google Cloud Storage from Kotlin or Java code.
Plus a bit of time to join the bits.
I will look into that in more detail tomorrow, but seems like not too much code there
l
@Nikky This is no longer a parent project.
And regarding that project, I bet it works there because it's delegating to Gradle, which we don't do for performance reasons.
n
hmm, then maybe update that in the contributions guidelines ?
l
That's planned already, we just didn't have the time to update it all yet
n
if you can provide me some pointers i think i can do the google cloud storage feature is there any special code for doing file based repos for example ?
l
I'll provide the pointers in the issue you opened once we're ready to accept the contribution. I'd like to add support for mavenLocal first, because it might require changes that could affect integrating GCS repos support.
n
i think there could be a abstraction layer there for
getFileContent(path: String): String
that either uses httpClient, loads from file or uses gcs
also feel free to push whatever you had planned for mavenLocal() i will rework the PR to fit
l
Am I right understanding that you would want this feature ASAP in refreshVersions?
n
i can wait actually.. i have a working version (in mavenLocal) that i can show to convince the tech team
l
You need to convince them to use refreshVersions or to sponsor refreshVersions?
n
i wish they would sponsor refreshVersions, but i don't think that will happen in the near future lets have them use it first
👍 1
i tried to test it but i think something in the setup or the new checks are slightly borked
Copy code
java.lang.IllegalStateException: java.lang.IllegalArgumentException: Expected a comment but found random text:
and such seems like it errors because there is something blank there but this is the file generated with the same version
l
@Nikky Did you remove the spaces between version entries?
n
was i supposed to do that ?
l
No
Alternatively, can you send me the
versions.properties
file via DM so I can reproduce?