Any recommendation to pass a `State` & `Side-E...

# orbit-mvi

[miqbaldc]

Any recommendation to pass a State & Side-Effect to a Composable screen, instead of passing the ViewModel?

ViewModel ref based on: https://github.com/orbit-mvi/orbit-sample-stocklist-jetpack-compose/blob/main/app/[…]otlin/org/orbitmvi/orbit/sample/stocklist/list/ui/ListScreen.kt

Code in 🧵

1️⃣ , 2️⃣ or 3️⃣ ?

[miqbaldc]

1️⃣

using_container.kt

[miqbaldc]

2️⃣

using_containerhost.kt

[miqbaldc]

3️⃣

using_state_kt.kt

[Benoît]

1️⃣ 2️⃣ :
I don't like the idea of passing the container to my composables, as it tight them to Orbit which isn't a good thing. Wether you pass a Container or a ContainerHost is roughly the same thing

3️⃣
Not sure where that snapshotFlow comes from

what about 4️⃣ : Passing a state: StateFlow and a sideEffect: Flow ?

[miqbaldc]

the 4️⃣ approach seems nice, as loosely coupled from both Orbit-MVI & Android ViewModel this ways.

[miqbaldc]

4️⃣

using_kotlin_flow_kt.kt

[Benoît]

I wouldn't call launch in LaunchedEffect, as you're already in a coroutine

[appmattus]

Why pass the state flow when you can simply pass an UpdateEmailState?

Side effects in compose are a funny one. Take a bottom sheet for example, the way compose is setup you are probably better off this being part of the state flow. It's worth reading https://proandroiddev.com/sending-view-model-events-to-the-ui-eef76bdd632c and Google's updated documentation.

[miqbaldc]

thanks, our first try was to use UpdateEmailState directly, until we implement side-effect