For guardrails, is there anything that checks for ...
# orbit-mvik
kenkyee
10/15/2021, 12:26 PMFor guardrails, is there anything that checks for people using vars or mutable state in data classes? Something like what mavericks has done:
https://airbnb.io/mavericks/#/debug-checks
a
appmattus
10/15/2021, 4:28 PMno not currently, we had internally discussed creating some detekt checks...
for one we've seen a few bug reports where ppl have not stored the container in a backing field and it would be great to spot that rather than an issue raised on the project
k
kenkyee
10/15/2021, 4:41 PMMight be good to start an issue and make a list of guardrails.... You wouldn't believe the strange stuff people do 🙂
a
appmattus
10/16/2021, 10:01 AMI've created this for the time being https://github.com/orbit-mvi/orbit-mvi/projects/1#card-70942584
k
kenkyee
10/18/2021, 6:19 PMalso got bit by not adding in .subscribeOn() before .await() for the RxJava interop...that'd be a nice lint guardrail too 🙂
Didn't seem to harm anything, but I did forget to do it..
4 Views