I ve a question regarding `intent` I ll add details in threa

Question

I ve a question regarding `intent` I ll add details in thread

Guilherme Delgado · Answer

let s consider the following code ```override val container = container lt LandingState LandingSideEffect gt LandingState hasSession = sessionManager hasSession stateHandle intent runBlocking ``` If I m querying async data network or repo what s the right approach A ```intent viewModelScope launch if sessionManager hasSession val result = fetch online operation state copy hasSession = result ``` B ``` viewModelScope launch if sessionManager hasSession val result = fetch online operation intent state copy hasSession = result ``` My confusion is regarding the `runBlocking` from `intent` ``` OrbitDsl public fun lt STATE Any SIDE EFFECT Any gt ContainerHost lt STATE SIDE EFFECT gt intent registerIdling Boolean = true transformer suspend SimpleSyntax lt STATE SIDE EFFECT gt gt Unit Unit = runBlocking container orbit withIdling registerIdling SimpleSyntax this transformer ```

Mikolaj Leszczynski · Answer

the answer is neither you re reading too much into internal code `intent` will launch a new coroutine internally You can see real examples in our and worth reading through our but generally something like this will be enough ```intent if sessionManager hasSession val result = networkCall Suspending function running within IO context reduce state copy hasSession = result ```

Guilherme Delgado · Answer

yup I ve read your documentation and saw the <https github com orbit mvi orbit sample stocklist jetpack compose|Stock List Jetpack Compose> example but it wasn t clear for me Thanks for point out slightly smiling face

Guilherme Delgado · Answer

`Threading guarantees ` `Calls to Container intent` do not block the caller The operations within are offloaded to an event loop style background coroutine ` `Generally it is good practice to make sure long running operations are done in a switched coroutine context in order not to block the Orbit event loop ` found it

Mikolaj Leszczynski · Answer

TL DR don t do blocking work within `intent`

Mikolaj Leszczynski · Answer

stuck out tongue

Mikolaj Leszczynski · Answer

but that advice applies pretty much everywhere not only orbit

miqbaldc · Answer

<https kotlinlang slack com archives CPM6UMD2P p1628758653031300 thread ts=1628757721 030600 amp cid=CPM6UMD2P|replied> Did it means we don t need to use `viewModelScope launch` anymore even we use `AndroidX ViewModel` cmiiw

Mikolaj Leszczynski · Answer

< miqbaldc> was `viewModelScope launch` ever something that we recommended I think it should be avoided because you re launching a coroutine outside of orbit container s scope If you re thinking about `coroutineScope ` then that is only needed for parallel decomposition or if you absolutely need to launch a coroutine within `intent`

Guilherme Delgado · Answer

we don t need to use viewModelScope inside `intent` but the container is scoped to ViewModel lifecycle or am I wrong thinking face gt creating containers scoped with to automatically cancel the whenever the `ViewModel` is cleared

Mikolaj Leszczynski · Answer

Yes it is

appmattus · Answer

< Guilherme Delgado> the posts sample would be a better sample to look at as that makes suspending network requests for its data whereas the stocklist gets all its data from a a streaming api using flows