https://kotlinlang.org logo
#graphql-kotlin
Title
# graphql-kotlin
e

Eamonn

12/02/2021, 9:39 AM
I wonder if the SpringGraphQLContextFactory needs some finesse. It currently requires us to implement the deprecated
override
suspend
_fun_ generateContext(request: ServerRequest)
while leaving the new
suspend fun generateContextMap(request: ServerRequest): Map<*, Any>?
optional. I wonder if it should not be the other way around - or for backwards compatibility give them both default implementations. Also in the documentation for Generating GraphQL Context in spring server, the examples are for the deprecated method. To me, as a newcommer, it's a little confusing - just my little bit of feedback. Keep up the good work!
d

Dariusz Kuc

12/02/2021, 1:33 PM
👋 thanks for the feedback. New context map was added as backwards compatible feature to v5. We will be fixing it in the next major release. Can you open up an issue so we dont forget to track it?
e

Eamonn

12/02/2021, 3:35 PM
Done
🙏 1
6 Views