Hi guys, this is regarding this <PR>. Want your su...

# koin-contributors

[Ruben Quadros]

Hi guys, this is regarding this PR. Want your suggestions. More info in the thread

[Ruben Quadros]

I was thinking of creating an extension function on ViewModelOwner in koin-androidx-navigation module and then calling this extension function from koin-androidx-compose getViewModel(..) func as follows:

fun ViewModelOwner.fromStoreOwner(storeOwner: ViewModelStoreOwner): ViewModelOwner = ViewModelOwner(
    store = storeOwner.viewModelStore,
    stateRegistry = stateRegistry,
    defaultArgs = if (storeOwner is NavBackStackEntry) storeOwner.arguments else null
)

inline fun <reified T : ViewModel> getViewModel(
    qualifier: Qualifier? = null,
    owner: ViewModelStoreOwner? = null,
    scope: Scope = GlobalContext.get().scopeRegistry.rootScope,
    noinline parameters: ParametersDefinition? = null,
): T {
    val storeOwner = owner?.let { ViewModelOwner.fromStoreOwner(it) } ?: getComposeViewModelOwner()
    return remember(qualifier, parameters) {
        scope.getViewModel(qualifier, { storeOwner }, parameters)
    }
}

[Ruben Quadros]

but this would still require koin-androidx-navigation dependency on
koin-androidx-compose

[Ruben Quadros]

@arnaud.giuliani sorry for the tag but would need your suggestion. Please check comments on PR as well 🙂

[arnaud.giuliani]

sure, let me see 👍

[Ruben Quadros]

Based on PR comments I have made the following changes:

inline fun <reified T : ViewModel> viewModel(
    qualifier: Qualifier? = null,
    owner: ViewModelStoreOwner? = null,
    scope: Scope = GlobalContext.get().scopeRegistry.rootScope,
    noinline parameters: ParametersDefinition? = null,
): Lazy<T> {
    val storeOwner = owner?.let { ViewModelOwner.fromCompose(it) } ?: getComposeViewModelOwner()
    val state = (owner as? NavBackStackEntry)?.arguments ?: storeOwner.defaultArgs
    return remember(qualifier, parameters) {
        ViewModelLazy(T::class, { storeOwner.storeOwner.viewModelStore }){
            getViewModelFactory<T>(
                owner = {storeOwner},
                qualifier = qualifier,
                parameters = parameters,
                scope = scope,
                state = state?.let { {it} } ?: emptyState()
            )
        }
    }
}

fun getComposeViewModelOwner(): ViewModelOwner {
    return ViewModelOwner.fromCompose(
        LocalViewModelStoreOwner.current!!,
        LocalSavedStateRegistryOwner.current
    )
}

fun ViewModelOwner.Companion.fromCompose(
    storeOwner: ViewModelStoreOwner,
    stateRegistry: SavedStateRegistryOwner? = null
) = ViewModelOwner(
    storeOwner = storeOwner,
    stateRegistry = stateRegistry,
    defaultArgs = (storeOwner as? NavBackStackEntry)?.arguments
)

fun ViewModelOwner.Companion.fromCompose(
    storeOwner: ViewModelStoreOwner
) = ViewModelOwner(
    storeOwner = storeOwner,
    defaultArgs = (storeOwner as? NavBackStackEntry)?.arguments
)

But ViewModelOwner will be deprecated next? If so, what should I use?

[arnaud.giuliani]

I believe in 3.2, I need to clean up the way we are composing all of this. With 3.1.6 patch, it brings things closer to last Google VM API

[arnaud.giuliani]

need a bit of time to make a concrete proposal

[Ruben Quadros]

Will be waiting for your reply/changes to proceed 🙏