I m opening this to discuss about the problem Koin is facing

Question

I m opening this to discuss about the problem Koin is facing with the usage of ViewModel + Compose + Navigation component on Android See <https kotlinlang slack com archives C67HDJZ2N p1628005816001100> for further info

arnaud.giuliani · Answer

great let me review it and see how we can organise

arnaud.giuliani · Answer

ok first to understand it will be how we can hook over ViewModel factory instances to keep a scoped instance for a nav graph

arnaud.giuliani · Answer

A regular ViewModel has its own factory managed by the underlying Android system

arnaud.giuliani · Answer

it will create the right instances by its own

arnaud.giuliani · Answer

Perhaps worse take a look at Hilt way of doing it thinking face

arnaud.giuliani · Answer

else play around the ViewModelFactory arguments

Nacho Ruiz Martin · Answer

Is this something to be addressed separately from Compose I mean the traditional way of injecting ViewModels should be able to scope it to a nav graph too right Is this already possible Also is Hilt open source

arnaud.giuliani · Answer

Need to check if Koin ViewModelFactory can get create from a given scope In the postivie case we could just adapt offer a way to work on navigation graph

arnaud.giuliani · Answer

else at least we need to be sure that ViewModel can be scoped create in a scope thinking face

arnaud.giuliani · Answer

I will take a bit of time to check your code I believe NavGraph scope with Koin can be quite easy

arnaud.giuliani · Answer

Ok we need similar to this <https developer android com training dependency injection hilt jetpack viewmodel navigation>

arnaud.giuliani · Answer

arf your sample is in compose stuck out tongue

arnaud.giuliani · Answer

would be great to go with dry API before making the Compose version

Nacho Ruiz Martin · Answer

Ok let me create another repo with traditional view system It ll be ready this week

arnaud.giuliani · Answer

oh yeah slightly smiling face great +1

Nacho Ruiz Martin · Answer

Hey man I was busy last week so I couldn t create the sample repo Do you still need it I ve seen that you re already working on the ViewModel API rework

arnaud.giuliani · Answer

I can perhaps work on official sample also thinking face

Nacho Ruiz Martin · Answer

I am able to help you with anything so feel free to ask for it

arnaud.giuliani · Answer

I just need to test the koinGraphApi on a sample something similar to <https cs android com androidx platform frameworks support + androidx main hilt hilt navigation fragment src main java androidx hilt navigation fragment HiltNavGraphViewModelLazy kt q=ViewModelLazy|https cs android com androidx platform frameworks support + androidx main hilt hil igation fragment HiltNavGraphViewModelLazy kt q=ViewModelLazy>

arnaud.giuliani · Answer

If you have something around it can help yes I don t know if there is a graph nav sample app thinking face

arnaud.giuliani · Answer

from google

Nacho Ruiz Martin · Answer

I don t know if there s one from Google but it should be super quick to do Let me handle that

arnaud.giuliani · Answer

ok just something super quick one activity 2 fragments to make just a transition and be sure we can handle a ViewModel from the nav graph

arnaud.giuliani · Answer

thanks pray

Nacho Ruiz Martin · Answer

Great muscle

Nacho Ruiz Martin · Answer

<https github com iruizmar koin nav compose view toy> There you have Very basic stuff let me know if you need something different

arnaud.giuliani · Answer

Great let me check that this week +1

arnaud.giuliani · Answer

finally another fix to help set a `ViewModelStoreOwner` and then the navigation one if needed

Nacho Ruiz Martin · Answer

Looks good +1

arnaud.giuliani · Answer

great