I’m opening this to discuss about the problem Koin...
# koin-contributorsn
Nacho Ruiz Martin
08/09/2021, 1:54 PMI’m opening this to discuss about the problem Koin is facing with the usage of ViewModel + Compose + Navigation component on Android. See https://kotlinlang.slack.com/archives/C67HDJZ2N/p1628005816001100 for further info.
a
arnaud.giuliani
08/09/2021, 4:00 PMgreat, let me review it and see how we can organise
arnaud.giuliani
08/12/2021, 4:07 PMok, first to understand it will be how we can hook over ViewModel factory instances to keep a scoped instance for a nav graph
arnaud.giuliani
08/12/2021, 4:07 PMA regular ViewModel has its own factory, managed by the underlying Android system
arnaud.giuliani
08/12/2021, 4:07 PMit will create the right instances by its own
arnaud.giuliani
08/12/2021, 4:08 PMPerhaps worse take a look at Hilt way of doing it 🤔
arnaud.giuliani
08/12/2021, 4:08 PMelse play around the ViewModelFactory arguments
n
Nacho Ruiz Martin
08/12/2021, 4:29 PMIs this something to be addressed separately from Compose? I mean, the traditional way of injecting ViewModels should be able to scope it to a nav graph too, right? Is this already possible?
Also, is Hilt open source?
a
arnaud.giuliani
08/26/2021, 9:11 AMNeed to check if Koin ViewModelFactory can get/create from a given scope. In the postivie case, we could just adapt/offer a way to work on navigation graph
arnaud.giuliani
08/26/2021, 9:12 AMelse at least, we need to be sure that ViewModel can be scoped/create in a scope 🤔
arnaud.giuliani
09/16/2021, 2:18 PMI will take a bit of time to check your code, I believe NavGraph scope with Koin can be quite easy
👍 1
🙇 1
arnaud.giuliani
09/27/2021, 4:12 PMOk, we need similar to this: https://developer.android.com/training/dependency-injection/hilt-jetpack#viewmodel-navigation
➕ 1
arnaud.giuliani
09/27/2021, 4:44 PMarf, your sample is in compose 😛
arnaud.giuliani
09/27/2021, 4:44 PMwould be great to go with “dry” API before making the Compose version
n
Nacho Ruiz Martin
09/27/2021, 6:26 PMOk, let me create another repo with traditional view system. It'll be ready this week.
a
arnaud.giuliani
09/28/2021, 8:10 AMoh, yeah 🙂 great 👍
n
Nacho Ruiz Martin
10/05/2021, 11:13 AMHey man, I was busy last week so I couldn’t create the sample repo.
Do you still need it? I’ve seen that you’re already working on the ViewModel API rework.
a
arnaud.giuliani
10/05/2021, 12:10 PMI can perhaps work on “official” sample also 🤔
n
Nacho Ruiz Martin
10/05/2021, 12:48 PMI am able to help you with anything, so feel free to ask for it.
a
arnaud.giuliani
10/05/2021, 2:22 PMI just need to test the koinGraphApi on a sample ... something similar to https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:hilt/hil[…]igation/fragment/HiltNavGraphViewModelLazy.kt?q=ViewModelLazy
arnaud.giuliani
10/05/2021, 2:22 PMIf you have something around, it can help yes. I don’t know if there is a graph nav sample app 🤔
arnaud.giuliani
10/05/2021, 2:22 PMfrom google
n
Nacho Ruiz Martin
10/07/2021, 9:34 AMI don’t know if there’s one from Google but it should be super quick to do. Let me handle that.
a
arnaud.giuliani
10/07/2021, 1:30 PMok, just something super quick. one activity 2 fragments, to make just a transition and be sure we can handle a ViewModel from the nav graph
arnaud.giuliani
10/07/2021, 1:30 PMthanks 🙏
n
Nacho Ruiz Martin
10/07/2021, 1:30 PMGreat! 💪
Nacho Ruiz Martin
10/08/2021, 2:14 PMhttps://github.com/iruizmar/koin-nav-compose-view-toy
There you have. Very basic stuff, let me know if you need something different.
a
arnaud.giuliani
10/12/2021, 10:17 AMGreat, let me check that this week 👍
arnaud.giuliani
12/07/2021, 6:10 PMfinally another fix to help set a
ViewModelStoreOwnerarnaud.giuliani
12/07/2021, 6:10 PMmessage has been deleted
n
Nacho Ruiz Martin
12/08/2021, 6:18 PMLooks good! 👍
a
arnaud.giuliani
12/09/2021, 9:01 AMgreat
4 Views