Seems that it’s deploying on maven central: <https...
# koin-contributors
a
Seems that it’s deploying on maven central: https://github.com/InsertKoinIO/koin/tree/maven_central
🎉 1
g
Sorry that took me so long 😞 But I ended up sending a PR here 🎉 https://github.com/InsertKoinIO/koin/pull/1022
Still, it has some open points
a
Many thanks @gammax 🙏 I can check to merge your PR into this branch then
g
As you wish, I can also integrate your changes 👍
a
I managed to gather resources in root, as all project are splitted up
g
As you wish. If yours already works you can drop mine no problem 👍
a
there is interesting stuff
I just need to be sure that MP part is well uploaded
g
Yeah, I decided to use KMM created publications. I saw that you create a new publication instead. Is there a reason?
a
use KMM created publications
I need to check then 🤔
g
a
`
Copy code
if (!pluginManager.hasPlugin('org.jetbrains.kotlin.multiplatform')) {
            publications {
                release(MavenPublication) {
                    if (pluginManager.hasPlugin('com.android.library')) {
                        from components.release
                    } else {
                        from components.java
                    }
                    artifact sourcesJar
                    artifactId = project.name
                }
            }
        }
you mean this then?
g
Correct
a
yeah, it’s perhaps a mistake
g
I also could not verify that Sonatype will accept those artifacts in the staging repository as I don’t have write rights to
io.koin
¯\_(ツ)_/¯
a
yeah
and ... I only have
io.insert-koin
domain 😛
g
Oh 😮
a
that’s why I pushed it in a variable 😄
g
☝️ Yeah I have to mention I’m not a big fan of having that variable around 😅
a
😄
g
I’d rather have the full coordinates everywhere. It’s also better for tools that are scanning your code (like dependedabot or others)
a
it’s more for internal usage 😛
👍 1
g
Also @arnaud.giuliani, would be worth to run a Diff of the .pom files
a
👍
exact, to be sure 🤔
@gammax do you know if the Multiplatform part is uploaded per platform, or if everything is now zipped in a
-all.jar
file?
For example here, I have a
koin-core-3.0.1-alpha-5-all.jar
file here: https://repo1.maven.org/maven2/io/insert-koin/koin-core/3.0.1-alpha-5/
it contains all kmp sources
g
I believe it’s uploaded per platform. That’s how the publishing looks like on my Maven Local:
Copy code
find . | grep koin
./koin-core-jvm
./koin-core-jvm/3.0.1-SNAPSHOT
./koin-core-jvm/3.0.1-SNAPSHOT/koin-core-jvm-3.0.1-SNAPSHOT.pom
./koin-core-jvm/3.0.1-SNAPSHOT/koin-core-jvm-3.0.1-SNAPSHOT-sources.jar
./koin-core-jvm/3.0.1-SNAPSHOT/koin-core-jvm-3.0.1-SNAPSHOT-javadoc.jar
./koin-core-jvm/3.0.1-SNAPSHOT/koin-core-jvm-3.0.1-SNAPSHOT.jar
./koin-core-jvm/3.0.1-SNAPSHOT/maven-metadata-local.xml
./koin-core-jvm/3.0.1-SNAPSHOT/koin-core-jvm-3.0.1-SNAPSHOT.module
./koin-core-jvm/maven-metadata-local.xml
./koin-core-macosx64
./koin-core-macosx64/3.0.1-SNAPSHOT
./koin-core-macosx64/3.0.1-SNAPSHOT/koin-core-macosx64-3.0.1-SNAPSHOT.klib
./koin-core-macosx64/3.0.1-SNAPSHOT/koin-core-macosx64-3.0.1-SNAPSHOT-javadoc.jar
./koin-core-macosx64/3.0.1-SNAPSHOT/koin-core-macosx64-3.0.1-SNAPSHOT-sources.jar
./koin-core-macosx64/3.0.1-SNAPSHOT/koin-core-macosx64-3.0.1-SNAPSHOT.module
./koin-core-macosx64/3.0.1-SNAPSHOT/koin-core-macosx64-3.0.1-SNAPSHOT.pom
./koin-core-macosx64/3.0.1-SNAPSHOT/koin-core-macosx64-3.0.1-SNAPSHOT-metadata.jar
./koin-core-macosx64/3.0.1-SNAPSHOT/maven-metadata-local.xml
./koin-core-macosx64/maven-metadata-local.xml
./koin-core-watchosarm64
./koin-core-watchosarm64/3.0.1-SNAPSHOT
./koin-core-watchosarm64/3.0.1-SNAPSHOT/koin-core-watchosarm64-3.0.1-SNAPSHOT.pom
./koin-core-watchosarm64/3.0.1-SNAPSHOT/koin-core-watchosarm64-3.0.1-SNAPSHOT-metadata.jar
./koin-core-watchosarm64/3.0.1-SNAPSHOT/koin-core-watchosarm64-3.0.1-SNAPSHOT.module
./koin-core-watchosarm64/3.0.1-SNAPSHOT/koin-core-watchosarm64-3.0.1-SNAPSHOT.klib
./koin-core-watchosarm64/3.0.1-SNAPSHOT/maven-metadata-local.xml
./koin-core-watchosarm64/3.0.1-SNAPSHOT/koin-core-watchosarm64-3.0.1-SNAPSHOT-javadoc.jar
./koin-core-watchosarm64/3.0.1-SNAPSHOT/koin-core-watchosarm64-3.0.1-SNAPSHOT-sources.jar
./koin-core-watchosarm64/maven-metadata-local.xml
./koin-core-iosx64
./koin-core-iosx64/3.0.1-SNAPSHOT
./koin-core-iosx64/3.0.1-SNAPSHOT/koin-core-iosx64-3.0.1-SNAPSHOT.pom
./koin-core-iosx64/3.0.1-SNAPSHOT/koin-core-iosx64-3.0.1-SNAPSHOT-metadata.jar
./koin-core-iosx64/3.0.1-SNAPSHOT/koin-core-iosx64-3.0.1-SNAPSHOT.module
./koin-core-iosx64/3.0.1-SNAPSHOT/koin-core-iosx64-3.0.1-SNAPSHOT-javadoc.jar
./koin-core-iosx64/3.0.1-SNAPSHOT/koin-core-iosx64-3.0.1-SNAPSHOT-sources.jar
./koin-core-iosx64/3.0.1-SNAPSHOT/koin-core-iosx64-3.0.1-SNAPSHOT.klib
./koin-core-iosx64/3.0.1-SNAPSHOT/maven-metadata-local.xml
./koin-core-iosx64/maven-metadata-local.xml
./koin-core-iosarm32
./koin-core-iosarm32/3.0.1-SNAPSHOT
./koin-core-iosarm32/3.0.1-SNAPSHOT/koin-core-iosarm32-3.0.1-SNAPSHOT-javadoc.jar
./koin-core-iosarm32/3.0.1-SNAPSHOT/koin-core-iosarm32-3.0.1-SNAPSHOT-sources.jar
./koin-core-iosarm32/3.0.1-SNAPSHOT/koin-core-iosarm32-3.0.1-SNAPSHOT-metadata.jar
./koin-core-iosarm32/3.0.1-SNAPSHOT/koin-core-iosarm32-3.0.1-SNAPSHOT.pom
./koin-core-iosarm32/3.0.1-SNAPSHOT/koin-core-iosarm32-3.0.1-SNAPSHOT.klib
./koin-core-iosarm32/3.0.1-SNAPSHOT/maven-metadata-local.xml
./koin-core-iosarm32/3.0.1-SNAPSHOT/koin-core-iosarm32-3.0.1-SNAPSHOT.module
./koin-core-iosarm32/maven-metadata-local.xml
./koin-core
./koin-core/3.0.1-SNAPSHOT
./koin-core/3.0.1-SNAPSHOT/koin-core-3.0.1-SNAPSHOT.module
./koin-core/3.0.1-SNAPSHOT/koin-core-3.0.1-SNAPSHOT-sources.jar
./koin-core/3.0.1-SNAPSHOT/koin-core-3.0.1-SNAPSHOT-javadoc.jar
./koin-core/3.0.1-SNAPSHOT/koin-core-3.0.1-SNAPSHOT-all.jar
./koin-core/3.0.1-SNAPSHOT/koin-core-3.0.1-SNAPSHOT.pom
./koin-core/3.0.1-SNAPSHOT/koin-core-3.0.1-SNAPSHOT.jar
./koin-core/3.0.1-SNAPSHOT/maven-metadata-local.xml
./koin-core/maven-metadata-local.xml
./koin-core-watchosx86
./koin-core-watchosx86/3.0.1-SNAPSHOT
./koin-core-watchosx86/3.0.1-SNAPSHOT/koin-core-watchosx86-3.0.1-SNAPSHOT.module
./koin-core-watchosx86/3.0.1-SNAPSHOT/koin-core-watchosx86-3.0.1-SNAPSHOT-sources.jar
./koin-core-watchosx86/3.0.1-SNAPSHOT/koin-core-watchosx86-3.0.1-SNAPSHOT.klib
./koin-core-watchosx86/3.0.1-SNAPSHOT/koin-core-watchosx86-3.0.1-SNAPSHOT-javadoc.jar
./koin-core-watchosx86/3.0.1-SNAPSHOT/koin-core-watchosx86-3.0.1-SNAPSHOT.pom
./koin-core-watchosx86/3.0.1-SNAPSHOT/maven-metadata-local.xml
./koin-core-watchosx86/3.0.1-SNAPSHOT/koin-core-watchosx86-3.0.1-SNAPSHOT-metadata.jar
./koin-core-watchosx86/maven-metadata-local.xml
./koin-core-tvosarm64
./koin-core-tvosarm64/3.0.1-SNAPSHOT
./koin-core-tvosarm64/3.0.1-SNAPSHOT/koin-core-tvosarm64-3.0.1-SNAPSHOT-sources.jar
./koin-core-tvosarm64/3.0.1-SNAPSHOT/koin-core-tvosarm64-3.0.1-SNAPSHOT-metadata.jar
./koin-core-tvosarm64/3.0.1-SNAPSHOT/koin-core-tvosarm64-3.0.1-SNAPSHOT-javadoc.jar
./koin-core-tvosarm64/3.0.1-SNAPSHOT/koin-core-tvosarm64-3.0.1-SNAPSHOT.module
./koin-core-tvosarm64/3.0.1-SNAPSHOT/koin-core-tvosarm64-3.0.1-SNAPSHOT.klib
./koin-core-tvosarm64/3.0.1-SNAPSHOT/koin-core-tvosarm64-3.0.1-SNAPSHOT.pom
./koin-core-tvosarm64/3.0.1-SNAPSHOT/maven-metadata-local.xml
./koin-core-tvosarm64/maven-metadata-local.xml
./koin-core-watchosarm32
./koin-core-watchosarm32/3.0.1-SNAPSHOT
./koin-core-watchosarm32/3.0.1-SNAPSHOT/koin-core-watchosarm32-3.0.1-SNAPSHOT.pom
./koin-core-watchosarm32/3.0.1-SNAPSHOT/koin-core-watchosarm32-3.0.1-SNAPSHOT.klib
./koin-core-watchosarm32/3.0.1-SNAPSHOT/koin-core-watchosarm32-3.0.1-SNAPSHOT.module
./koin-core-watchosarm32/3.0.1-SNAPSHOT/koin-core-watchosarm32-3.0.1-SNAPSHOT-javadoc.jar
./koin-core-watchosarm32/3.0.1-SNAPSHOT/koin-core-watchosarm32-3.0.1-SNAPSHOT-sources.jar
./koin-core-watchosarm32/3.0.1-SNAPSHOT/maven-metadata-local.xml
./koin-core-watchosarm32/3.0.1-SNAPSHOT/koin-core-watchosarm32-3.0.1-SNAPSHOT-metadata.jar
./koin-core-watchosarm32/maven-metadata-local.xml
./koin-core-iosarm64
./koin-core-iosarm64/3.0.1-SNAPSHOT
./koin-core-iosarm64/3.0.1-SNAPSHOT/koin-core-iosarm64-3.0.1-SNAPSHOT-metadata.jar
./koin-core-iosarm64/3.0.1-SNAPSHOT/koin-core-iosarm64-3.0.1-SNAPSHOT-javadoc.jar
./koin-core-iosarm64/3.0.1-SNAPSHOT/koin-core-iosarm64-3.0.1-SNAPSHOT-sources.jar
./koin-core-iosarm64/3.0.1-SNAPSHOT/maven-metadata-local.xml
./koin-core-iosarm64/3.0.1-SNAPSHOT/koin-core-iosarm64-3.0.1-SNAPSHOT.module
./koin-core-iosarm64/3.0.1-SNAPSHOT/koin-core-iosarm64-3.0.1-SNAPSHOT.klib
./koin-core-iosarm64/3.0.1-SNAPSHOT/koin-core-iosarm64-3.0.1-SNAPSHOT.pom
./koin-core-iosarm64/maven-metadata-local.xml
./koin-core-js
./koin-core-js/3.0.1-SNAPSHOT
./koin-core-js/3.0.1-SNAPSHOT/koin-core-js-3.0.1-SNAPSHOT-javadoc.jar
./koin-core-js/3.0.1-SNAPSHOT/koin-core-js-3.0.1-SNAPSHOT.module
./koin-core-js/3.0.1-SNAPSHOT/koin-core-js-3.0.1-SNAPSHOT-sources.jar
./koin-core-js/3.0.1-SNAPSHOT/koin-core-js-3.0.1-SNAPSHOT.pom
./koin-core-js/3.0.1-SNAPSHOT/maven-metadata-local.xml
./koin-core-js/3.0.1-SNAPSHOT/koin-core-js-3.0.1-SNAPSHOT.jar
./koin-core-js/maven-metadata-local.xml
./koin-core-linuxarm32hfp
./koin-core-linuxarm32hfp/3.0.1-SNAPSHOT
./koin-core-linuxarm32hfp/3.0.1-SNAPSHOT/koin-core-linuxarm32hfp-3.0.1-SNAPSHOT.pom
./koin-core-linuxarm32hfp/3.0.1-SNAPSHOT/koin-core-linuxarm32hfp-3.0.1-SNAPSHOT.module
./koin-core-linuxarm32hfp/3.0.1-SNAPSHOT/koin-core-linuxarm32hfp-3.0.1-SNAPSHOT-sources.jar
./koin-core-linuxarm32hfp/3.0.1-SNAPSHOT/koin-core-linuxarm32hfp-3.0.1-SNAPSHOT-javadoc.jar
./koin-core-linuxarm32hfp/3.0.1-SNAPSHOT/koin-core-linuxarm32hfp-3.0.1-SNAPSHOT.klib
./koin-core-linuxarm32hfp/3.0.1-SNAPSHOT/maven-metadata-local.xml
./koin-core-linuxarm32hfp/maven-metadata-local.xml
./koin-core-linuxx64
./koin-core-linuxx64/3.0.1-SNAPSHOT
./koin-core-linuxx64/3.0.1-SNAPSHOT/koin-core-linuxx64-3.0.1-SNAPSHOT.klib
./koin-core-linuxx64/3.0.1-SNAPSHOT/koin-core-linuxx64-3.0.1-SNAPSHOT-sources.jar
./koin-core-linuxx64/3.0.1-SNAPSHOT/koin-core-linuxx64-3.0.1-SNAPSHOT-javadoc.jar
./koin-core-linuxx64/3.0.1-SNAPSHOT/maven-metadata-local.xml
./koin-core-linuxx64/3.0.1-SNAPSHOT/koin-core-linuxx64-3.0.1-SNAPSHOT.pom
./koin-core-linuxx64/3.0.1-SNAPSHOT/koin-core-linuxx64-3.0.1-SNAPSHOT.module
./koin-core-linuxx64/maven-metadata-local.xml
./koin-core-tvosx64
./koin-core-tvosx64/3.0.1-SNAPSHOT
./koin-core-tvosx64/3.0.1-SNAPSHOT/koin-core-tvosx64-3.0.1-SNAPSHOT.module
./koin-core-tvosx64/3.0.1-SNAPSHOT/koin-core-tvosx64-3.0.1-SNAPSHOT-sources.jar
./koin-core-tvosx64/3.0.1-SNAPSHOT/koin-core-tvosx64-3.0.1-SNAPSHOT-javadoc.jar
./koin-core-tvosx64/3.0.1-SNAPSHOT/koin-core-tvosx64-3.0.1-SNAPSHOT.pom
./koin-core-tvosx64/3.0.1-SNAPSHOT/koin-core-tvosx64-3.0.1-SNAPSHOT-metadata.jar
./koin-core-tvosx64/3.0.1-SNAPSHOT/koin-core-tvosx64-3.0.1-SNAPSHOT.klib
./koin-core-tvosx64/3.0.1-SNAPSHOT/maven-metadata-local.xml
./koin-core-tvosx64/maven-metadata-local.xml
Oh there is also this:
Copy code
./koin-core/3.0.1-SNAPSHOT/koin-core-3.0.1-SNAPSHOT-all.jar
a
yeah, but then I’m missing all .module & .klib stuff I believe
I will try again with your version then
g
Seems like not 🤔
Copy code
find . | grep koin | grep -E "module|klib"
./koin-core-jvm/3.0.1-SNAPSHOT/koin-core-jvm-3.0.1-SNAPSHOT.module
./koin-core-macosx64/3.0.1-SNAPSHOT/koin-core-macosx64-3.0.1-SNAPSHOT.klib
./koin-core-macosx64/3.0.1-SNAPSHOT/koin-core-macosx64-3.0.1-SNAPSHOT.module
./koin-core-watchosarm64/3.0.1-SNAPSHOT/koin-core-watchosarm64-3.0.1-SNAPSHOT.module
./koin-core-watchosarm64/3.0.1-SNAPSHOT/koin-core-watchosarm64-3.0.1-SNAPSHOT.klib
./koin-core-iosx64/3.0.1-SNAPSHOT/koin-core-iosx64-3.0.1-SNAPSHOT.module
./koin-core-iosx64/3.0.1-SNAPSHOT/koin-core-iosx64-3.0.1-SNAPSHOT.klib
./koin-core-iosarm32/3.0.1-SNAPSHOT/koin-core-iosarm32-3.0.1-SNAPSHOT.klib
./koin-core-iosarm32/3.0.1-SNAPSHOT/koin-core-iosarm32-3.0.1-SNAPSHOT.module
./koin-core/3.0.1-SNAPSHOT/koin-core-3.0.1-SNAPSHOT.module
./koin-core-watchosx86/3.0.1-SNAPSHOT/koin-core-watchosx86-3.0.1-SNAPSHOT.module
./koin-core-watchosx86/3.0.1-SNAPSHOT/koin-core-watchosx86-3.0.1-SNAPSHOT.klib
./koin-core-tvosarm64/3.0.1-SNAPSHOT/koin-core-tvosarm64-3.0.1-SNAPSHOT.module
./koin-core-tvosarm64/3.0.1-SNAPSHOT/koin-core-tvosarm64-3.0.1-SNAPSHOT.klib
./koin-core-watchosarm32/3.0.1-SNAPSHOT/koin-core-watchosarm32-3.0.1-SNAPSHOT.klib
./koin-core-watchosarm32/3.0.1-SNAPSHOT/koin-core-watchosarm32-3.0.1-SNAPSHOT.module
./koin-core-iosarm64/3.0.1-SNAPSHOT/koin-core-iosarm64-3.0.1-SNAPSHOT.module
./koin-core-iosarm64/3.0.1-SNAPSHOT/koin-core-iosarm64-3.0.1-SNAPSHOT.klib
./koin-core-js/3.0.1-SNAPSHOT/koin-core-js-3.0.1-SNAPSHOT.module
./koin-core-linuxarm32hfp/3.0.1-SNAPSHOT/koin-core-linuxarm32hfp-3.0.1-SNAPSHOT.module
./koin-core-linuxarm32hfp/3.0.1-SNAPSHOT/koin-core-linuxarm32hfp-3.0.1-SNAPSHOT.klib
./koin-core-linuxx64/3.0.1-SNAPSHOT/koin-core-linuxx64-3.0.1-SNAPSHOT.klib
./koin-core-linuxx64/3.0.1-SNAPSHOT/koin-core-linuxx64-3.0.1-SNAPSHOT.module
./koin-core-tvosx64/3.0.1-SNAPSHOT/koin-core-tvosx64-3.0.1-SNAPSHOT.module
./koin-core-tvosx64/3.0.1-SNAPSHOT/koin-core-tvosx64-3.0.1-SNAPSHOT.klib
a
I have them locally too
but their not pushed to maven central
g
I do see them (at least in the
-SNAPSHOT
publishing I did under
com.ncorti
on Sonatype): https://oss.sonatype.org/content/repositories/snapshots/com/ncorti/koin-core-tvosx64/3.0.1-SNAPSHOT/
a
ok, great 👍
I didn’t understood how I inject my oss credentials for maven central
I have everything ready in a
local.properties
file
g
I’m unsure
local.properties
would work. What I do is either:
• Create an environment variable called:
SONATYPE_NEXUS_USERNAME
and so on… • Add an entry in your
~/.gradle/gradle.properties
with:
Copy code
org.gradle.project.SONATYPE_NEXUS_USERNAME=cortinico
and so on
a
yes, this part then
g
Yup
a
thanks, I will test this 👍
I will go with your PR
thank again for your contribution 🙂
❤️ 1
g
For the GPG key, that’s a bit painful if you do it locally. That’s also why I left a comment there.
a
I have my gpg files and stuff
g
Awesome 👍
a
great 🙂
g
Should I update the package name in mine? Or you want to follow-up afterwards?
a
if you can update to
io.insert-koin
, yes would be great 🙏
just merged your PR. I will do the next steps 👍
g
Oh great 🚀
a
3.0.1 is almost ready ... and compose beta is out 🙂
Failed to publish publication ‘iosArm32’ to repository ‘staging’
> Could not PUT ‘https://oss.sonatype.org/service/local/staging/deploy/maven2/io/insert-koin/koin-core-iosarm32/3.0.1-alpha-6/koin-core-iosarm32-3.0.1-alpha-6.klib’. Received status code 401 from server: Unauthorized
arf 😞
did you got something like that?
ok typo in password 🤦
g
Oh so it worked?
m
Is this can be related with latest changes somehow ? https://github.com/CurrencyConverterCalculator/CCC/commit/2b543211a7cb2519105748cb6d06a73417ef1b22/checks#step:5:86
Copy code
Could not resolve org.koin:koin-core-js:3.0.1-alpha-5.
a
alpha-6 is ok, not alpha-5
m
is it published already ? It is failed to resolve
a
on maven central yes:
maven group id for koin is now
io.insert-koin
m
Ohh that’s the reason! thanks a lot! I confirm it is working now