hihi, just create a new pr to move root Scope creation from KoinApplication to ScopeRegistry. Please...

Jintin

11/30/2020, 4:32 AM

hihi, just create a new pr to move root Scope creation from KoinApplication to ScopeRegistry. Please let me know if it helps or not. https://github.com/InsertKoinIO/koin/pull/967

arnaud.giuliani

11/30/2020, 8:57 AM

good observations 👍

arnaud.giuliani

11/30/2020, 9:02 AM

let me check that

Jintin

11/30/2020, 9:44 AM

Thanks

Jintin

12/03/2020, 2:22 AM

any comment on this?

arnaud.giuliani

12/04/2020, 8:17 AM

have to be sure to re-run all test apps from the samples

arnaud.giuliani

12/04/2020, 8:17 AM

not sure the CI is testing it à 100%

Jintin

12/04/2020, 10:04 AM

oh got it, thanks. let me know if anything wrong.

arnaud.giuliani

12/04/2020, 10:16 AM

👍

5 Views

kotlinlang

A modern programming language that makes developers happier.