https://kotlinlang.org logo
#koin-contributors
Title
# koin-contributors
j

Jeziel Lago

08/18/2020, 1:09 PM
Hey everyone! I open a PR fixing errors on kotlin 1.4 https://github.com/InsertKoinIO/koin/pull/873
@arnaud.giuliani could you check it?
a

arnaud.giuliani

08/18/2020, 1:39 PM
Thanks @Jeziel Lago 👍
My other thinking is ... perhaps to remove this time API as it is breaking all the time 🙄
j

Jeziel Lago

08/18/2020, 2:07 PM
maybe rewrite without kotlin.time?
a

arnaud.giuliani

08/18/2020, 2:44 PM
exact
I as using the old system. time in ms ...
if I remember 🤔
can be enough
j

Jeziel Lago

08/18/2020, 2:45 PM
I rewrote without
kotlin.time
.
a

arnaud.giuliani

08/18/2020, 2:45 PM
cool 👍
just fix yoru variables, and it will be ok 👍
j

Jeziel Lago

08/18/2020, 3:00 PM
Done! 😄
n

Nick

08/26/2020, 5:59 PM
I’m trying to fix this in 3.0 (yay hopefully my first open source contribution!) I’m also still a beginner to MPP so go easy on me :). I think if we want these changes to work on multiplatform, we’d have to provide an
actual
to get the system clock, or go back to using Kotlin.time (
measureTime
and
measureTimedValue
seem nice) You guys mentioned that this API keep changing and/or breaking? that’s so unfortunate.
a

arnaud.giuliani

08/27/2020, 7:30 AM
I think if we want these changes to work on multiplatform,  we’d have to provide an 
actual
 to get the system clock, or go back to using Kotlin.time (
measureTime
 and 
measureTimedValue
 seem nice)
exact
2 Views