Hey everyone! I open a PR fixing errors on kotlin 1.4 <https://github.com/InsertKoinIO/koin/pull/873...

# koin-contributors

[Jeziel Lago]

Hey everyone!
I open a PR fixing errors on kotlin 1.4
https://github.com/InsertKoinIO/koin/pull/873

[Jeziel Lago]

@arnaud.giuliani could you check it?

[arnaud.giuliani]

Thanks @Jeziel Lago 👍

[arnaud.giuliani]

My other thinking is ... perhaps to remove this time API as it is breaking all the time 🙄

[Jeziel Lago]

maybe rewrite without kotlin.time?

[arnaud.giuliani]

exact

[arnaud.giuliani]

I as using the old system. time in ms ...

[arnaud.giuliani]

if I remember 🤔

[arnaud.giuliani]

can be enough

[Jeziel Lago]

I rewrote without kotlin.time.

[arnaud.giuliani]

cool 👍

[arnaud.giuliani]

just fix yoru variables, and it will be ok 👍

[Jeziel Lago]

Done! 😄

[Nick]

I’m trying to fix this in 3.0 (yay hopefully my first open source contribution!) I’m also still a beginner to MPP so go easy on me :).

I think if we want these changes to work on multiplatform, we’d have to provide an actual to get the system clock, or go back to using Kotlin.time (measureTime and measureTimedValue seem nice)

You guys mentioned that this API keep changing and/or breaking? that’s so unfortunate.

[arnaud.giuliani]

I think if we want these changes to work on multiplatform,  we’d have to provide an actual to get the system clock, or go back to using Kotlin.time (measureTime and measureTimedValue seem nice)

exact