Hi all I m trying to implement clickability to transaction b kotlinlang #chucker

Channels

kotlin-foundation

compose-android

ohio-kotlin-users

kotlin-by-example

sofl-user-group

kotlin-multiplatform-contest

tricity-kotlin-user-group

kotlin-in-action

android-databinding

cincinnati-user-group

fluid-libraries

codemash-precompiler

kotlingforbeginners

jhipster-kotlin

prozis-android-backup

realworldkotlin

graviton-browser

spring-security

domain-driven-design

connect-audit-events

swiss-user-group

effectivekotlin

refactoring-to-kotlin

russian-kotlinasfirst

androidgithubprojects

introduce-yourself

pocketgitclient

effective-kotlin

algolialibraries

lambdaworld_cadiz

intellij-tricks

kotlin-pakistan

navigation-architecture-component

strife-discord-lib

machinelearningbawas

leedskotlinusergroup

stayhungrystayfoolish

kotest-contributors

practical-functional-programming

swagger-gradle-codegen

100daysofkotlin

kotlinultimatechallenge

pattern-matching

kotlinforbeginners

competitive-programming

compose-ui-showcase

competitivecoding

kotlin-data-storage

skia-wasm-interop-temp

java-to-kotlin-refactoring

event21-community-content

androidx-xprocessing

embedded-kotlin

fb-internal-demo

image-processing

myndocs-oauth2-server

kotlintest-devs

beepiz-libraries

kotlinprogrammers

cscenter-course-2016

k2-early-adopters

intellij-plugins

language-proposals

library-development

refreshversions

language-evolution

kotlinx-datetime

framework-elide

compose-desktop

jvm-ir-backend-feedback

android-architecture

100daysofkotlin-2021

github-workflows-kt

python-contributors

squarelibraries

arrow-contributors

codingconventions

getting-started

Title

b

Bilgehan KALKAN

04/13/2021, 8:59 AM

Hi all, I'm trying to implement clickability to transaction body line items. This feature is requested by our team since our requests contains urls for next requests. What do you think of adding this to Chucker? https://github.com/ChuckerTeam/chucker/compare/develop...bilgehankalkan:feature/clickable-url

g

gammax

04/13/2021, 9:00 AM

transaction body line items

Hey 👋 Do you mean clickable URLs inside the body?

b

Bilgehan KALKAN

04/13/2021, 9:08 AM

Yes

g

gammax

04/13/2021, 9:10 AM

I think it would be a nice addition. The reality is that the body is split in single lines, so you would have to handle URLs that splits across multiple lines.

b

Bilgehan KALKAN

04/13/2021, 9:16 AM

Yes but I thought that url's will be single liner if library specifically not split the response body. I will check that of course.

I checked HttpTransaction#formatBody, it creates lines from JSON response. So if the response field is not splitted, it will be parsed correctly. Also if the response has multiline URL, URL would be like

<http://www.website>\<http://n.com/pathone/path|n.com/pathone/path>\ntwo/pathtree

and would be already broken.

@gammax Opened PR for this. https://github.com/ChuckerTeam/chucker/pull/609

g

gammax

04/13/2021, 4:01 PM

Thanks for taking the time. I can’t promise that this will be merged (mostly for the broken URL thing), but I will take a look over the next days 🙏

👍 1

4 Views

#chucker Join Slack