Hey guys! I've just found the channel and first wo...

# chucker

[Tayfun Cesur]

Hey guys! I've just found the channel and first would like to tell you my thanks! You are really doing great job!

In my personal project, I just felt that it would be better to clear all transaction history every time app opens
Because the old history makes noises and confusions. After some investigation, I found that RetentionManager
It has ONE_HOUR minimum but it may not be enough for everyone. I'd prefer to have retentionPeriod : Long instead of enum.

Before I create a feature request, I wanted to ask here first in case of I missed sth. Please tell me, if I did.
And let me know your thoughts about having long retentionPeriod.
Thanks in advance :)

[Vova Buberenko]

Hey Tayfun. First of all welcome 🙂

Good idea. Feel free to open a feature request with your request. Rework of ChuckerCollector API is one of features I work on to improve it and implement notifications customisation as requested in https://github.com/ChuckerTeam/chucker/issues/406

Would gladly consider updates for retention period options as well.

[gammax]

Thanks for raising your point. To address your scenario still a Long sounds like a workaround to me. Ideally we could have a special enum value to address “every app restart”.

[Tayfun Cesur]

Hey guys, thank you for your warm welcome . @Vova Buberenko, I will have a look at that issue also,
@gammax, yeah Long could be too relaxed but it would fit every scenario. IMHO, keeping it as enum would always have some missing cases 🙂

[gammax]

We can still evolve it to a sealed class

[Vova Buberenko]

I believe that we could just introduce boolean property to enable db clear on every app startup and have it as a function in a builder for ChuckerCollector

[Vova Buberenko]

We already have a breaking change in the API for 4.x. I would prefer to break one more API, because we also need to add some parameters for notifications customisation.

[Tayfun Cesur]

Thanks guys, please let me know about your decision. Then I can create the issue if you want.

[gammax]

Yes please :)

[Vova Buberenko]

Tayfun - you can already fill the issue with your feature request so we track it properly. I like the idea of having DB cleared on new app launch, for example and having custom retention period might also be worthy. Just describe your use case and how you feel it would be better to configure retention, so others could see and join if needed.

[Tayfun Cesur]

ok Volodymyr, gonna do it asap 🙂 I can join as well

[MiSikora]

We can always add a new overload that accepts long or a more specialised type. In method overload that accepts enums we would just map to this class. But I agree that having a breaking change in 4.x for this is not that troublesome.

Anyway, I would also appreciate opening an issue so it is easier to discuss and exchange ideas.

[Tayfun Cesur]

https://github.com/ChuckerTeam/chucker/issues/522
🚀