any plans to migrate to kotlin coroutines ?
# chucker
n
any plans to migrate to kotlin coroutines ?
m
Which part of Chucker would you want to migrate to coroutines and why?
v
Yes, we have such plans, but it is not top priority at the moment.
Top priority items are: 1. Fix for issue done in #250 (it is done already, just waiting for the confirmation from the issue reporter) 2. Add GraphQL support (you can check discussion in https://github.com/ChuckerTeam/chucker/pull/70 ) 3. Fix the problem from https://github.com/ChuckerTeam/chucker/issues/218 So if you want to help with contributions, take a look at those issues.
m
Which part do you want to migrate to coroutines? Room and then other parts that use it?
v
I think he wanted to migrate AsyncTasks
m
Ah, right. Forgot about that 🙂
v
But I migth be wrong 😄
n
yeah async tasks as well as in room/viewmodels etc
m
It’s not Canary issue but IDE auto formatting. Until https://github.com/ChuckerTeam/chucker/issues/249 is resolved you have to align code style yourself or adjust IDE rules for the project according to the Detekt rules.
You can see in the logs that it is mostly wrong indentation and import issues https://github.com/ChuckerTeam/chucker/runs/495906572?check_suite_focus=true. Or just run
check
task locally.
One thing that cannot be fixed with the IDE is the import ordering due to https://youtrack.jetbrains.com/issue/KT-10974
n
Cool. Thanks. Will fix that.
m
Hey @Nikhil, I left two minor comments.
👍 1
v
@Nikhil you don't need to ping people and send to the channel as well. There are notifications on Github as well as here due to threads. Please respect other people and don't spam with multiple notifications.
👍 1