Hi there! I am having problems with jsTest and jsBrowserTest in a multiplatform project. On my machi...

# kotest

[peekandpoke]

Hi there! I am having problems with jsTest and jsBrowserTest in a multiplatform project. On my machine tests are no longer executed for JS.

When I create a test like

"FAIL!" {
   fail("BOOOM!")
}

I still see all tests being successful.

The test suite also worked last week and the JS and Common tests where executed properly and suddenly stopped doing so. Does anyone have an idea what is wrong here.

I am running on Ubuntu 20.04 and Kotest 5.2.3, Kotlin 1.6.20. I also know that my browsers where updated last week...
So yeah am I lost here. Any help, ideas or pointers is very much appreciated!

[sam]

It seems like something broke in 1.6.20

[peekandpoke]

So am I not the only one with this issue?

[sam]

@Jim has it too I think

[Jim]

Yeah 😔 I abandoned updating to .20 for now

[sam]

If you can track down the issue @Jim I might be able ot fix

[peekandpoke]

Thank you for your help. I can confirm that 1.6.10 works for as well. I have the feeling the Js-Code is generated differently in 16.20, and maybe it optimizes the Test classes away...

[peekandpoke]

After looking into the generated JS code for the test runner I see this:

EDIT: talking about 1.6.20 in the message below

[peekandpoke]

I have two tests, one in commonTest, one in jsTest

[peekandpoke]

[peekandpoke]

The js code does this:

[peekandpoke]

[peekandpoke]

Somehow the JavascriptSpec appears in the common section...

[peekandpoke]

... i have not clue what this really means, and maybe this is totally ok. It just looks a bit odd.

[peekandpoke]

In 1.6.10 the JS-Code looks like this

[peekandpoke]

[peekandpoke]

and below there is

[peekandpoke]

[peekandpoke]

Ok... and then again in 1.6.20 :

[peekandpoke]

[peekandpoke]

init_properties_CommonSpec_kt_658525396

is called here:

[peekandpoke]

[peekandpoke]

and guess where _get_launcher__806741035 is called?

[peekandpoke]

Right, nowhere...

[peekandpoke]

Is this maybe related to this new feature of 1.6.20? https://kotlinlang.org/docs/whatsnew1620.html#lazy-initialization-of-top-level-properties-by-default-with-ir-compiler

[peekandpoke]

@sam and @Jim what do you think?

[sam]

Yeah I think that sounds like the issue.

[sam]

the compiler plugin places all the specs into a val

[Jim]

Now that you mention it I read in the either #javascript or #react that JavaScript wasn't auto running

[peekandpoke]

Should I create an issue in kotest/kotest? @sam

[sam]

pls

[peekandpoke]

Is this ok? https://github.com/kotest/kotest/issues/2929

[peekandpoke]

Or should I go into more detail in the issue description?

[sam]

That's good

[Jim]

I was digging through the docs and it looks like here in the "what's new for 1.6.20" they suggest using the @EagerInitialization annotation

If for some reason you need to initialize a property eagerly (upon the application start), mark it with the @EagerInitialization annotation.

Wondering if we can slap that on whatever generates getLauncher

[sam]

Yeah but seems to be native only? Unless they just haven't updated the docs yet

[Jim]

Yeah I imagine not, cause that's directly under the JS IR section in the what's new docs

[Jim]

I can't find where that get_launcher comes from 🤔

[sam]

the compiler plugin prob

[Jim]

That's not in here is it? https://github.com/kotest/kotest-gradle-plugin/tree/master/src/main/kotlin/io/kotest/gradle

[sam]

maybe its a new thing generated by the js compiler

[Jim]

ok I'm not able to import that annotation, so we might just be dead in the water here 🤔

[peekandpoke]

Hey! What would happen when we make the launcher field NOT final here:

[peekandpoke]

https://github.com/kotest/kotest/blob/master/kotest-framework/kotest-framework-mul[…]/kotest/framework/multiplatform/js/SpecIrGenerationExtension.kt

[peekandpoke]

The idea being to make the field a "var" instead of a "val". Maybe a var is not lazily initialized.

[peekandpoke]

@sam and @Jim what do you think?

[sam]

Can try it

[Jim]

I'll try to include that in my annotation change

[Jim]

I'll try to get a PR out over lunch

[sam]

https://github.com/kotest/kotest/pull/2947

[Jim]

Sam is the fastest 🙏

[peekandpoke]

🦜

[benkuly]

Will there be a release soon or is there a way to use the snapshot builds of the plugin?

[sam]

today probably, I'm trying to get the intellij plugin working so that we can run individual JS / Native tests

[benkuly]

Until the release: Are there snapshot builds of the plugin? I saw, that there are oss snapshots, but what is the plugin naming?

[sam]

This isn't a plugin thing, you can use the latest kotest snapshot

[benkuly]

I thought for JS we need the multiplatform plugin?

[sam]

it's all controlled by the main kotest library

[sam]

Try 5.3.0.968-SNAPSHOT

[benkuly]

Perfect, thank you. And what does io.kotest.multiplatform?

[sam]

you can stick wtih 5.2.3 for that, it hasn't changed

[sam]

If you can confirm it works @benkuly I will release 5.3.0

[benkuly]

Yes it works, thanks. Sadly I have nested tests and therefore all tests are failing on JS 😕

[sam]

they worked before ?

[sam]

or is this a new project

[benkuly]

nope. added js as target recently.

[peekandpoke]

Nested JS tests are not supported

[sam]

ahhh I see

[sam]

Yeah you can't use nested JS tests because the JS frameworks don't support parent tests as async

[benkuly]

Yes, already saw that... 😞

[peekandpoke]

Hey! I just wanted to confirm that the JS-test are running fine again for all of my projects. Thanks @sam and all the others in this thread!