I'm sure someone has asked this but I can't find it... Just upgraded to 5.0.3 and my tagging strate...

# kotest

[Rob Elliot]

I'm sure someone has asked this but I can't find it...

Just upgraded to 5.0.3 and my tagging strategy to avoid running tests that need to start a docker container seems to no longer work - looks like the tests are skipped, but the listener still starts the container:

internal class AuctionSniperEndToEndContainerTest : StringSpec({

  tags(Docker)

  listener(openfireTestContainer(Paths.get("../docker-openfire")).perSpec())
  ...
}

[Rob Elliot]

Where the tag is used like this:

import io.kotest.core.Tag
import io.kotest.core.TagExpression
import io.kotest.core.TagExpression.Companion.Empty
import io.kotest.core.TagExpression.Companion.exclude
import io.kotest.core.extensions.TagExtension

object Docker : Tag()

object DockerTagExtension : TagExtension {

  override fun tags(): TagExpression =
    if (shouldRunDockerTests()) Empty else exclude(Docker)

  private fun shouldRunDockerTests() = !runningAsPartOfBuild()

  private fun runningAsPartOfBuild() = System.getenv("BUILD_SYSTEM") != null
}

[sam]

can you make a test in one of the skipped specs test("foo") { error("boom") }

[sam]

just to make sure it is being skipped

[sam]

will help me to narrow down the issue

[Rob Elliot]

Definitely skips the test

[sam]

ok my guess is the tag isn't being used properly

[sam]

how are you setting the tag

[Rob Elliot]

Calling fun tags(vararg tags: Tag) in the block passed to StringSpec's constructor

[Rob Elliot]

(See OP)

[sam]

no I mean at runtime

[sam]

to enable/disable "docker"

[sam]

oh never mind I see it

[Rob Elliot]

Oh, by reading a System property - see second post.

[sam]

ok how do you register the tag extension

[Rob Elliot]

import io.kotest.core.config.AbstractProjectConfig

@Suppress("unused") // read by reflection
object ProjectConfig : AbstractProjectConfig() {
  override fun extensions() = listOf(DockerTagExtension)
}

[sam]

you shouldn't need @Suppress("unused") // read by reflection on latest plugin btw

[sam]

unless that wasn't released yet

[sam]

the intellij plugin should be doing that for you automatically

[sam]

anyway

[sam]

ok this is enough for me to write a repeater

[Rob Elliot]

Thanks!

[sam]

I clean forgot about this. Is this still happening, I guess so ?

[Rob Elliot]

Yes, it's still happening - just upgraded to 5.1.0 and still an issue

[sam]

Ok

[sam]

Sorry that i missed it

[Rob Elliot]

NP, thanks - I haven't had a chance to dig into it further I'm afraid.

At a personal level it's no big deal, just a side project and even in that it was a convenience way to debug failing tests locally.

[sam]

I'll try for 5.1.1