I'm having some issues with the migration, notably with the Koin integration. The KoinExtension regi...

# kotest

[Maxr1998]

I'm having some issues with the migration, notably with the Koin integration. The KoinExtension registers a beforeAny that filters TestType.Test, I previously declared my DI mocks in beforeEach so that I didn't have to do that extra check. However, with Kotest 5.0, beforeEach gets called before beforeAny in TestExtensions, which causes my mocks to fail because Koin hasn't started yet.
I wonder if the order in TestExtensions should be changed again, as I'd expect the outer scopes to evaluate before inner scopes, thus container → any → each.

[Maxr1998]

Additionally, the KoinExtension hasn't apparently been updated to 5.0.0 yet, as using the KoinLifecycleMode.Root causes a NoSuchMethodException.

[sam]

Outer scope listeners will fire first

[sam]

but perhaps what you're seeing here is the beforeAny of the inner firing before the beforeEach of the inner

[Maxr1998]

I should've been more clear, I'm observing that beforeEach (which I register in the spec constructor) is called before the beforeAny that the KoinExtension uses.

[Maxr1998]

Previously, that wasn't the case

[sam]

Do you have an example layout ?

[sam]

the test contents don't matter, just the structure

[sam]

and the callbacks

[Maxr1998]

class Sample : DslDrivenSpec(), StringSpecRootScope, KoinTest {

    lateinit var mockedProperty: SessionRepository

    init {
        beforeEach {
            mockedProperty = declareMock()
        }

        "Some test case" {

        }
    }

    override fun extensions() = listOf(
        KoinExtension(
            modules = listOf(appModule, authModule),
            mockProvider = { clazz -> mockkClass(clazz) },
        ),
    )
}

[Maxr1998]

That's an example of what I'm doing right now

[Maxr1998]

The problem is that beforeEach with the declareMock is executed before the KoinExtension is run

[sam]

Why are you extending dsl driven spec and root scope ?

[Maxr1998]

Because my base class for tests does a few other things, just copy pasted this sample. It also fails when extending StringSpec normally.

[sam]

ok

[sam]

I makes sense that beforeAny should run before beforeEach since it's more general

[sam]

But the trouble with trying to order beforeXX operations is that however you do it, someone somewhere will want it the other way.

[sam]

Let me try to think of a better solution.

[sam]

Probably moving the KoinExtension to be an interceptor will do the trick, then it will always run first.

[Maxr1998]

But the trouble with trying to order beforeXX operations is that however you do it, someone somewhere will want it the other way.

True, it was just a bit surprising that it changed after the upgrade. But I agree a more general solution would be preferable.

[Maxr1998]

Probably moving the KoinExtension to be an interceptor will do the trick, then it will always run first.

Is that something that I can do or does it have to be changed in the extension?

[sam]

Yeah in the extension

[sam]

But I can do that now and release a 5.0 compatible release

[sam]

It won't take long assuming it works

[Maxr1998]

That would be very appreciated, thank you!

[Maxr1998]

Thanks for the update, looks promising! Gonna try it out tomorrow.

[sam]

How did you know 🙂

[sam]

Was about to tell you

[Maxr1998]

Actually, I randomly opened the GitHub and saw you push like a minute ago. Very random and a bit scary 😆

[sam]

haha

[Maxr1998]

But yeah, I'll give it a go tomorrow / once it's published.

[sam]

snapshot is automatically published https://oss.sonatype.org/content/repositories/snapshots/io/kotest/extensions/kotest-extensions-koin/

[sam]

if you use latest (remember to add snapshots maven repo)

[sam]

and it works, I will publish 1.1.0

[sam]

I've tweaked docs too. https://kotest.io/docs/extensions/koin.html

[Maxr1998]

Ok, I'll try and report back!

[Maxr1998]

I think the default is still the per-test mode though?

[sam]

yes, I just wanted to make it clear you could change it

[sam]

the docs are somewhat lacking

[sam]

I'm not even sure myself what the KoinTest interface does

[Maxr1998]

Ah ok, just because the tests explicitly use Test in the second sample, thought it should maybe outline the root mode there.

[Maxr1998]

KoinTest is just a simple marker to allow resolving Koin components

[Maxr1998]

It's actually just an alias to KoinComponent

[Maxr1998]

Might do other things too, but I haven't come across those yet

[sam]

Ah ok

[sam]

So it's needed? I don't know koin very well

[sam]

I've updated the docs to reverse the KoinLifecycleMode example

[Maxr1998]

It's necessary to use declareMock

[Maxr1998]

If I find the time, I can open a PR for the docs tomorrow and make them a bit clearer

[sam]

Yeah taht would be awesome

[Maxr1998]

Update: new version works perfectly!

[sam]

awesome

[Maxr1998]

When are you planning to release it to the stable channel then?

[sam]

can do it now

[Maxr1998]

Nice. I just opened a PR for the docs. Conceptually, it was fine, but the code sample had a small mistake and I made the lifecycle mode option a bit clearer.

[Maxr1998]

Open for suggestions though.

[sam]

looks good

[Maxr1998]

Thanks for the merge!

[sam]

1.1.0 released, takes 30 minutes to show up