Channels
#kotest
Title
# kotest
s
Sebastian Schuberth
11/28/2021, 9:45 AMI'm running into more troubles after migrating to Kotest 5.0.0. Can it be that the order in which
beforeTestTestListenerbeforeTestbeforeTests
sam
11/28/2021, 3:49 PMIt could be the order got changed. No guarantees are given on the order in which the same type of callbacks are invoked. Although we could introduce a guarantee.
s
Sebastian Schuberth
11/28/2021, 3:56 PMYes, I definitely think order should be guaranteed and documented. Also, having special
registerFirst()registerLast()s
sam
11/28/2021, 3:56 PMYou could also just wrap all your listeners in a CompositeListener class which executes in a given order.
We could provide such a wrapper.
It's going to get very complicated if we have registerFirst in addition to all the other callbacks
s
Sebastian Schuberth
11/28/2021, 3:58 PMA composite listener would not help me right away, as I'm using a test class hierarchy with a mix of listeners and overridden callback functions. Let's see how I can clean this up...
No guarantees are given on the order in which the same type of callbacks are invoked.Is that also the case when I register listeners A and B by passing an ordered list to
register()A.beforeTest()B.beforeTest()s
sam
11/28/2021, 4:25 PMTechnically no guarantees, practically, in order. All extensions/listeners end up in this list: https://github.com/kotest/kotest/blob/5be5cbef245bcfc1a1665c5196edb7f21a198ed8/kot[…]rc/commonMain/kotlin/io/kotest/core/config/ExtensionRegistry.kt
So they will definitely be executed in order. We could extend that guarantee to 5.0.0, since it's the current behavior, and add a test / docs for it.
👍🏻 1
s
Sebastian Schuberth
11/28/2021, 4:32 PMAnd practically, how about any listeners from extensions vs. overridden functions? Are overridden function always called before any listeners from the extension registry?
s
sam
11/28/2021, 4:33 PMThis is the current order
Copy code
return spec.extensions() + // overriding the extensions function in the spec
spec.listeners() + // overriding the listeners function in the spec
spec.functionOverrideCallbacks() + // dsl
spec.registeredExtensions() + // added to the spec via register
registry.all() // globals👍🏻 1
There's your beforeTest guarantees
s
Sebastian Schuberth
11/28/2021, 4:52 PMThanks a lot! Would it make sense to also add a
override fun beforeTest()FunSpecs
sam
11/28/2021, 4:53 PMyep can do
❤️ 1
I'll sprinkle a few about.
Done, if you want to check
s
Sebastian Schuberth
11/28/2021, 5:34 PMAwesome, thanks!
s
sam
11/28/2021, 5:34 PMNo problem
3 Views