what's the best way to generate "whitespace or empty" strings using `Arb`?

# kotest

[dimsuz]

what's the best way to generate "whitespace or empty" strings using Arb?

[sam]

Could quickly write one, would be a good PR actually

[dimsuz]

What should it be based on?

Some Arb<Codepoint> which uses the same as the CharSet.WHITESPACE (saw it in sources, but it's private). Ah, but that would need an empty case which is not a Codepoint

[sam]

if you want something that has more white space than just 1

[sam]

arbitrary { List(it.random.nextInt(10)).joinToString(" ") }

[sam]

or something

[sam]

(not tested in ide)

[dimsuz]

oh, nice, thank you. I can send PR a bit later if needed.

Would Arb.whitespace() be a good name?

[sam]

yep

[LeoColman]

Is an empty string a whitespace tho?

[LeoColman]

Maybe create two versions, Arb.whitespace() and Arb.whitespaceOrEmpty()

[LeoColman]

that way the suggestions inside intellij will be very intuitive

[LeoColman]

what do you guys think?

[sam]

I think " " is whitespace

[sam]

not sure about empty string

[LeoColman]

Kotlin has String.isBlank()

[LeoColman]

which returns true for empty string

[sam]

ahh so that's a better term

[sam]

Arb.blanks() ?

[LeoColman]

(for empty and for whitespace)

[LeoColman]

"*A String is blank when either its length is zero or it contains only whitespace characters"*

[LeoColman]

I'm also for to just have an extension on Arb<String>: arb.orEmpty(). I don't know if we have this already or somethingn similar

[sam]

yeah if we don't we can add the blanks one. I think that's a good suggestion.

[dimsuz]

Also I'm not sure about this: should this also produce "\t" characters? nbsp characters too? maybe anything for which Char.isWhitespace() returns true? or only ascii spaces?

Or maybe kotlin's isBlank() could be used as a guideline, i.e. Arb.blanks().map { it.isBlank() } == [true]

[sam]

I think the latter, isBlank should be true