If I do ```someArb.take(10).toList()``` and then feed it to data test's `forAll` it only makes me on...

# kotest

[dave08]

If I do

someArb.take(10).toList()

and then feed it to data test's forAll it only makes me one test 🤕?

[sam]

there's 200 data tests now

[sam]

which one are you using

[dave08]

suspend fun <T : Any> ContainerContext.forAll(ts: List<T>, test: suspend (T) -> Unit)

[sam]

so the new one from 4.5+

[dave08]

4.6

[sam]

what is .toList doing

[sam]

is it making a list of t, or a list of a single element of list(t)

[dave08]

I guess converting the sequence from arb's take to a list...?

[sam]

here is a funky example

[sam]

withData("p", "q") { a ->
      withData(listOf("r", "s")) { b ->
         withData(sequenceOf("x", "y")) { c ->
            a + b + c shouldHaveLength 3
            results.add(a + b + c)
         }
      }
   }

[sam]

so it should all be working

[sam]

The docs have been updated for 4.6 https://kotest.io/docs/framework/datatesting/data-driven-testing.html

[dave08]

I don't have withData...? I think I might have some kind of caching problem...

[dave08]

But Intellij shows me:

[sam]

its in kotest-framework-datatest

[sam]

but that should be coming in automatically

[dave08]

[sam]

yeah its not

[sam]

damn that's an oversight

[sam]

I'd add that module yourself

[sam]

the DD testing is way better now

[sam]

it does proper nesting and everything

[dave08]

Well still the same problem... still only have one sample generated...

[sam]

what if you do withData(listOf(1,2) ){ a -> }

[dave08]

Puzzling, I have to step out right now, but I tried that (using arb to generate to singles into a list) and still got one test... I'm using instancePerLeaf and it inside the withData block...

[sam]

try pasting it in exactly what I put, just to rule out the data test framework

[sam]

instance per leaf might be the issue

[sam]

yes now I think about it, it definitely is

[dave08]

But I need it so that my test setup can be reinitialized, is it supposed to work?

[sam]

not for data tests

[sam]

as they're dynamic so it can't find them again on the next pass

[dave08]

Well at least it should fail with a proper error message?

[sam]

agreed

[dave08]

PerTest would still work with data tests?

[dave08]

If so, it could be suggested as a replacement in the error.

[sam]

no that won't work either probably

[sam]

just single instance

[dave08]

Oh... Then it might be nice to have some kind of memoized construct like in spek? To reinitialize setup, since that's one of the reasons why i use InstancePerLeaf all the time

[sam]

it wouldn't help with data tests

[sam]

If you want to create a ticket, I will look into what can be done for 5.0

[dave08]

Ok, I'll try to remember tomorrow when I get to work, thanks!

[christophsturm]

if each context invocation uses the same random seed it would always create the same tests. that could be an easy fix.

[dave08]

@sam Does beforeTest work with data tests?

[sam]

Yes

[dave08]

kotlin.UninitializedPropertyAccessException: lateinit property requestSequence has not been initialized

[dave08]

lateinit var requestSequence: Sequence<InitializeAccountRequest>

init {
    isolationMode = IsolationMode.SingleInstance

    describe("Initialization of account") {
        beforeTest {
            registrationState = setupRegistrationState(RegistrationState.arbValid().single()) {
                requestSequence = InitializeAccountRequest.arb(
                    odooDevice!!.id, oroAccount!!.id
                ).take(10)
            }
        }

        withData(requestSequence) { request ->

[sam]

The nested before test might be causing a bug

[sam]

It should work. I'm afk atm will check soon

[dave08]

Yeah, when I take it out of describe it works...

[sam]

Probably easy fix

[dave08]

Can I use beforeContainer to setup before each data set?

[sam]

Yes

[dave08]

Oh boy! I suppose that withData grabs all the values from the sequence BEFORE it runs the test?

[dave08]

Since it seems that when I assert the state of the repos in the lateinit var already change... and they all fail.

[dave08]

So beforeContainer doesn't help at all in such a case...

[dave08]

And should withData contain `it`s or is it a test in itself @sam?

[sam]

withData makes the tests for you

[sam]

its basically like doing forEach with a test / it inside

[dave08]

Oh... so asserting multiple named assertions isn't possible then... I usually put the Arrange and Act in a context and Assert in a bunch of `it`s to verify multiple assertions on the state coming out of the Act.

[sam]

you can add further nests tests

[sam]

withData(listOf(1,2)) { a ->

   context("set me up") { 
   }

    it("run me") {

    }
}

[dave08]

So basically the same as:

it("..") {
   context("...") {
      it("...") {
         ...
      }
   }
}

and that works?

[sam]

well not tried it but I don't see why it wouldn't

[dave08]

only when surrounded by context? Also, maybe that's what caused my previous problems... https://kotlinlang.slack.com/archives/CT0G9SD7Z/p1621951379106600?thread_ts=1621871119.093600&cid=CT0G9SD7Z

[dave08]

the beforeContainer might not be doing the initialisation properly when doing that...

[dave08]

And w/o nesting (no it inside withData), I get a funny <init> on a failing test...

[dave08]

Using #strikt for assertions that seem to work nicely with kotest so far...

[sam]

yes if you wanted to use them

[sam]

Kotest's assertions are richer

[sam]

you can use both together

[dave08]

But why the <init>?

[sam]

you might have an error outside of the test, I don't knnow

[sam]

and yes withData will materialize the full list

[dave08]

Which makes it impossible to use lateinit vars in the class's context with SingleInstance... and still make sure they have the same state when asserting....

[sam]

I think you can do what you want

[dave08]

I'm a bit stuck with the setup part here... 🤕

[sam]

Do you have a full example

[dave08]

I'll try to DM part of it...