Using the DataLayer code in the Wear OS samples, I am getting this warning: `This method should only...

# compose-wear

[Nat Strangerweather]

Using the DataLayer code in the Wear OS samples, I am getting this warning:
This method should only be accessed from tests or within private scope
Should I just ignore it?

[Ataul Munim]

Which method

[Nat Strangerweather]

This one:

private fun sendPhoto() {
        lifecycleScope.launch {
            try {
                val image = clientDataViewModel.image ?: return@launch
                val imageAsset = image.toAsset()
                val request = PutDataMapRequest.create(IMAGE_PATH).apply {
                    dataMap.putAsset(IMAGE_KEY, imageAsset)
                    dataMap.putLong(TIME_KEY, Instant.now().epochSecond)
                }
                    .asPutDataRequest()
                    .setUrgent()

                val result = dataClient.putDataItem(request).await()

                Log.d(TAG, "DataItem saved: $result")
            } catch (cancellationException: CancellationException) {
                throw cancellationException
            } catch (exception: Exception) {
                Log.d(TAG, "Saving DataItem failed: $exception")
            }
        }
    }

[Ataul Munim]

There should be a specific method that warning applies to - is this a code comment or an IDE warning?

[Nat Strangerweather]

An IDE warning

[Nat Strangerweather]

on a few code parts

[Nat Strangerweather]

like :

.asPutDataRequest()
.setUrgent()

[Nat Strangerweather]

message has been deleted

[Ataul Munim]

You can use CMD+click to navigate to those methods and see their definition/more info

[Nat Strangerweather]

Well it says @VisibleForTesting but I'm not sure what to do about it.

[Nat Strangerweather]

I'm currently using the sample to adapt it to my own needs.

[Ataul Munim]

If it's visible for testing it shouldn't be used except in tests. It's either that it's incorrectly marked as such or the sample should be updated.

[Nat Strangerweather]

There are other bits that have the same warnings

[Ataul Munim]

same deal. If this is a sample on GitHub, please could you open an issue saying that the sample is using code which is marked as visible for testing 🙏

[Nat Strangerweather]

ok will do!

[Ataul Munim]

Ta!

[yschimke]

Fixed in next release? https://issuetracker.google.com/issues/239451111

[yschimke]

But a bug on the sample would be great as we should suppress these warnings also.

[Nat Strangerweather]

Hope I've done it properly: https://issuetracker.google.com/u/2/issues/260484640

[yschimke]

I suspect @Ataul Munim meant here https://github.com/android/wear-os-samples/issues, also that bug seems to be at the top level without a component, so not sure it will get routed correctly. But it should get cleaned up anyway.

[Ataul Munim]

I'll look tomorrow - thanks for raising!