https://kotlinlang.org logo
Title
w

wasyl

03/17/2021, 2:09 PM
Small feedback: I just updated Kotest from 4.4.0 to 4.4.3 and some of my tests started failing because of this change: https://github.com/kotest/kotest/commit/650e00befec2a6320fd9bc5eb3d921de759230e8#diff-8e93023b4ef7e14183574357e70[…]0aa56f52830450b7824903dc5c4a4cf0. It’s not documented in the Github releases (I later realized proper changelog is at https://kotest.io/docs/changelog.html), so you might consider: • bumping minor version for behavior changes. This change was categorized as a bugfix, but throwable matchers have worked like this forever • removing content from the Github releases page that looks like a changelog (e.g. https://github.com/kotest/kotest/releases/tag/v4.4.1) and/or linking to actual changelog entry
s

sam

03/17/2021, 2:11 PM
Good feedback. Especially on the matcher change. Github releases page should have no changelog. Must be auto generated so I'll turn it off
w

wasyl

03/17/2021, 2:14 PM
You can perhaps link to the given release like https://kotest.io/docs/changelog.html#441-february-2021 if it’s not too much effort, it’s useful to be able to open changelog directly from email for example
s

sam

03/17/2021, 2:36 PM
I've updated 4.4.0 through 4.4.3 in github with the changelog links
🙇 1