for the first, the tests aren't nested and so when they start to repeat through the inner loop on th...

# kotest

[snowe]

for the first, the tests aren't nested and so when they start to repeat through the inner loop on the second outer loop, I get 'duplicate' test name errors.

but if I create that test internally, now there are two tests with that name. Here is a demonstration of the issue by just adding a prefix to the test

[sam]

Can you paste up the code for the first example

[sam]

save me typing it all out

[snowe]

class PrintDrlTest : FreeSpec({

    "test" - {
        forAll("a", "b", "c") { outer ->
            forAll("1", "2", "3") { inner ->
                println("$outer$inner")
            }
        }
    }

    "test 2" - {
        forAll("a", "b", "c") { outer ->
            "prefix: $outer" - {
                forAll("1", "2", "3") { inner ->
                    println("$outer$inner")
                }
            }
        }
    }
})

[snowe]

I'm on 4.4.1

[sam]

Ah ok I see

[sam]

Take this part:

[sam]

"test" - {
        forAll("a", "b", "c") { outer ->
            forAll("1", "2", "3") { inner ->
                println("$outer$inner")
            }
        }
    }

[sam]

that's just two nested loops, and the outer loop won't be joined with the inner loop for a test name

[sam]

like it looks like the tests will be nested but they won't be because you're not creating inner tests

[sam]

It's no difference to going

test("a") { }
test("1") { }
test("2") { }
test("b") { }
test("1") { }
test("2") { }

[snowe]

for either of those they're not really nested? How do I get them to nest then? I tried test 2 without the prefix and have the issue of the duplicate top level tests

[snowe]

see my most recent pictures in the main channel

[sam]

If you want to nest tests, then just roll your own loop

[sam]

"test" - {
        listOf("a", "b", "c").forEach { outer ->
           "$outer" - {
                 listOf("1", "2", "3").forEach { inner ->
                        "$inner" - {
                              println("$outer$inner")
                        }
                  }
               }
        }
    }

[snowe]

what does the forAll accomplish then? If it needs to be nested in a test to begin with, and you can't nest them without this issue.

[sam]

forAll is special syntax that will create tests for you (basically doing what I pasted above)

[snowe]

yes I realize that.

[snowe]

just seems like it should work to nest as well. I'll just roll my own loop.

[sam]

nested tests are created at runtime, because it's just nested lambdas right. So when the code is compiled with forAll it binds to the closest statically created test loop. so in your example, the closest loop is the top level "test"- block. The inner block doesn't exist until runtime.

[snowe]

oh. that makes sense. alright. thanks!

[sam]

I can see why it's not intuitive. Let me make a ticket to see if we can make the whole thing defer until runtime.

[sam]

https://github.com/kotest/kotest/issues/2078

[snowe]

awesome. thanks for that!

[sam]

thanks for the feedback, always good to keep improving things

[snowe]

welcome! I was just really confused by it all. couldn't understand why it was making the top ones twice.

[sam]

Wasn't obvious to me either at first lol