Have there been any changes to exceptions matchers in 4.4.0? Some of our tests started failing and i...

# kotest

[wasyl]

Have there been any changes to exceptions matchers in 4.4.0? Some of our tests started failing and it turns out previously the exceptions that we compared didn’t have matching cause. Is there an issue I can read to see what’s changed exactly?

[sam]

shouldThrow ?

[wasyl]

We had something like

val exception = shouldThrowAny { /* code */ }

it("should throw $expected") {
    exception shouldBe expected
}

[wasyl]

exception shouldBe expected started failing now

[sam]

Is it correctly failing now and wasn't before ?

[wasyl]

Yes 🙂

[sam]

So it's an improvement 🙂

[sam]

but I'm not sure of anything that changed

[wasyl]

It is 🙂 I’m just looking to see what changed to better understand how it impacts other tests we might have

[sam]

let me check the code

[sam]

Last changes 31st may

[sam]

https://github.com/kotest/kotest/tree/master/kotest-assertions/kotest-assertions-shared/src/commonMain/kotlin/io/kotest/assertions/throwables

[wasyl]

Found it https://github.com/kotest/kotest/commit/68bd5705defa32431f807a17b3da5d2fce4be950

[sam]

oooooh

[wasyl]

Actually not sure yet this is it, but it seems relevant (our exception is a data class for some reason)

[sam]

you had data class exceptions

[sam]

yeah

[wasyl]

Oh yeah, so previously we’d just check the message & instance as per ThrowableEq#equals

[wasyl]

now we’re checking the entire class 👍 Thanks 🙂

[sam]

Yeah, I suppose that was a bug / oversight

[sam]

glad it's been fixed

[sam]

@Ashish Kumar Joy swoops in and fixes all the bugs :)