Separate question - shouldn't `minIterations` for ...
# kotest
k
Separate question - shouldn't
minIterations
for
Arb
include at least one sample? Right now it counts only all edge cases https://github.com/kotest/kotest/blob/master/kotest-property/src/commonMain/kotlin/io/kotest/property/Gen.kt#L39
s
I suppose it depends whether you think the edge cases are the minimum required or whether you should include at least one "random" value too.
k
sure, but right now it is used to check if the number of iterations is >= minIterations I'd argue if someone wants to test only edge cases they will use Exhaustive instead of an Arb
s
I agree.
k
Awesome, if I simply raise a PR that adds +1 to
this.edgecases().size
it will be a breaking change. How to proceed in such a case?
s
I have merged in code to fix your other issue - I think the "calculate min iterations" code should do this (the +1) but only if it's enabled by a flag in
PropertyTesting
so it's not a breaking change. In the future we can perhaps make this the default.
k
cheers