Ok regarding the Robolectric extension let s go by small ste kotlinlang #kotest

Ok regarding the Robolectric extension, let’s go by small steps. First thing first, I’ve noticed it isn’t generating in the latest versions of the library (the last extension version available in the maven repo is the

4.0.1

). I’ve created a PR to re-include the plugin in the project artefacts generation, unless there was a reason why it wasn’t included anymore (@sam to confirm). The PR is this one, it includes also some further fixes and optimisations in the Gradle file. After that, I will try to reproduce the bugs about Robolectric itself, although from some comments I understand it might be not as immediate to fix them.

sam

10/05/2020, 10:53 AM

It was moved to the android repo

alexfacciorusso

10/05/2020, 10:54 AM

Oh I see, but how come it is still in the main one?

sam

10/05/2020, 10:54 AM

https://github.com/kotest/kotest-android

I guess we never deleted it

But Leonardo was talking about moving it back to the main one anyway

So I think its good to move it back. The only thing I would do, is check that no commits were added to the other repo that are missing from your PR.

alexfacciorusso

10/05/2020, 10:57 AM

No problem; I’ll make a diff and commit every change if any from the Android project to the main one, and make a PR also for the deletion in the Android repo. Btw off-topic, a test in

master

is failing https://github.com/kotest/kotest/pull/1757/checks?check_run_id=1208652750

and it’s not regarding my PR even though is failing in my PR

sam

10/05/2020, 10:59 AM

Test null probability values can be specified[jvm] FAILED

It's a probabilistic test, you might just have gotten unlucky

I've kicked it off again

alexfacciorusso

10/05/2020, 11:00 AM

Shouldn’t we add a retry policy on that one?

sam

10/05/2020, 11:01 AM

yep

alexfacciorusso

10/05/2020, 11:01 AM

👍🏻

sam

10/05/2020, 11:02 AM

Want me to do that in master ?

alexfacciorusso

10/05/2020, 11:03 AM

Actually I might try doing it myself and make a PR if you don’t mind 😄

👍🏻 1

https://github.com/kotest/kotest/pull/1758

3 Views

#kotest Join Slack