https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hiring-french
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
w

wasyl

07/14/2020, 9:42 AM
I asked a while back but didn’t follow up: what was the reasoning to remove
context
block in
DescribeSpec
? @sam you mentioned (in https://kotlinlang.slack.com/archives/CT0G9SD7Z/p1593192969030900) that now nested describe blocks are allowed, but they were allowed for almost a year, since 3.4 I think. I’m asking primarily since it’s a bit surprising to see such breaking change between 4.0 and 4.1
s

sam

07/15/2020, 3:13 AM
It simplifies the creation of intellij plugins, but it shouldn't have been removed. I will add them back in for 4.1.2 and deprecate them, so your code will work
w

wasyl

07/15/2020, 6:31 AM
If they’re deprecated then we won’t use them regardless, because we use
-Werror
🙂 Migration is really straightforward so I don’t mind in terms of that, only I know some of the team here enjoyed the distinction between
context
and
describe
since it’s how RSpec works
We considered our own alias function, but then from what I understand it also wouldn’t play well with IJ plugin, right?
Yep, with an alias we see
duplicated test name
error because our context is ignored for the purposes of the check apparently
s

sam

07/18/2020, 3:51 PM
4.1.2 released with context restored to DescribeSpec. It is deprecated but only as a warning.
w

wasyl

07/18/2020, 4:03 PM
Thanks 🙂 I’m afraid we’ll still not be able to use it, but maybe someone will 😉 My 2 questions: - would bringing back
context
, thus keeping
DescribeSpec
more consistent with RSpec, be considered? - would you accept a contribution to IJ plugin that somehow addresses our issue? Generally we appreciate having a separately named container to differentiate between blocks that change system context vs blocks that perform an action
I’d have to look at the plugin code, but perhaps a
@TestContainer
annotation on a method that denotes opening another scope would make sense? I’ll provide more details when I have something, but in general the plugin currently doesn’t play well with neither custom alias or even extracting pieces of test functionality into methods. Since it doesn’t recognise other methods, some of our tests are all red from “duplicate test name” error, even though tests with the same names are nested differently
s

sam

07/18/2020, 4:06 PM
Ok that last point is definitely a major bug. Can you create an example that causes it and I'll get that fixed
w

wasyl

07/18/2020, 4:08 PM
Yep, I plan reporting couple of issues to IJ plugin (especially around instance-per-leaf tests), but most likely tomorrow
s

sam

07/18/2020, 4:08 PM
Instance per leaf with the messed up nesting?
I should have remembered your earlier message about wanting to use context because it's consistent with rspec. I thought you just needed a workaround for now. Let me look into supporting context again properly.
👍 1
w

wasyl

07/18/2020, 4:10 PM
yep, the tests in the “run” window are nested one inside another, with some entries duplicated:
- test1
    - test2
       - test3
         …
                                     -testx
s

sam

07/18/2020, 4:10 PM
If you're using 4.1.x then that was fixed in 4.1.2
👍 1
w

wasyl

07/18/2020, 4:19 PM
Yess, I confirm what I was seeing is fixed with 4.1.2, great 🙂
s

sam

07/18/2020, 4:19 PM
So we just need to add context back in now properly
w

wasyl

07/18/2020, 4:27 PM
Here’s another thing that doesn’t work properly
It’s a pattern we have sometimes, and now I see it doesn’t execute assertions 😕 I wanted to paste it as an example of duplicated test name error (which doesn’t appear here, interestingly):
class SomeClass(
    private val dependency: AtomicInteger
) {

    fun getText() = dependency.get().toString()
}

class UtilMethodExampleSpec : DescribeSpec() {

    val integer = AtomicInteger()
    val sut = SomeClass(integer)

    init {
        describe("SomeClass") {
            withIntValue(4) {
                describe("text") {
                    val result = sut.getText()

                    it("should be '4'") {
                        result shouldBe 4
                    }
                }

                withIntValue(6) {
                    describe("text") {
                        val result = sut.getText()

                        it("should be '6'") {
                            result shouldBe 6
                        }
                    }
                }
            }

            withIntValue(5) {
                describe("text") {
                    val result = sut.getText()

                    it("should be '5'") {
                        result shouldBe 5
                    }
                }
            }

        }
    }

    private suspend fun DescribeScope.withIntValue(value: Int, block: suspend DescribeSpec.() -> Unit) {
        context("given integer value is $value") {
            integer.set(value)
            block()
        }
    }

    override fun isolationMode(): IsolationMode = IsolationMode.InstancePerLeaf
}
The pattern is to create methods
suspend fun DescribeScope.someStateDescription(<state values>, block: suspend DescribeSpec.() -> Unit)
to quickly open context/describe blocks which sometimes do multiple things. For this particular example it seems like no test is even executed:
s

sam

07/18/2020, 7:02 PM
private suspend fun DescribeScope.withIntValue(value: Int, block: suspend DescribeSpec.() -> Unit) {
        context("given integer value is $value") {
            integer.set(value)
            block()
        }
    }
That needs to be changed to
private suspend fun DescribeScope.withIntValue(value: Int, block: suspend DescribeScope.() -> Unit) {
        context("given integer value is $value") {
            integer.set(value)
            block()
        }
    }
The block() is being called on the top level describe, which has no effect
w

wasyl

07/18/2020, 10:04 PM
Ahhh that's right, sorry :/ anyway, I'll be reporting the issues as I go, I tried quickly reproducing something and made a mistake 😒imple_smile:
👍🏻 1
Hey @sam, I just wanted to ask what’s the status of
context
on
DescribeSpec
going back. We’re holding back on updating to recent release because
context
is deprecated (and it shadows our extension) and we have
-Werror
flag on 😕 I understand if it’s not priority, just then we’ll rename our extension and wait. Or maybe there’s something I can contribute to help with this?
You're just waiting on a release of 4.2
You could use the rc1
w

wasyl

08/13/2020, 6:59 PM
That’s great news 🙂 I saw rc release but thought it’s just a technical one, related to github workflow. Is it compatible with IJ plugin?
s

sam

08/13/2020, 7:03 PM
Yes works with 1.0.5 and 1.1.9 plugins
4.2.0 final is just waiting on kotlin 1.4 final
w

wasyl

08/13/2020, 7:04 PM
Ah, got it. Do we need Kotlin 1.4 rc as well?
s

sam

08/13/2020, 7:05 PM
It should work on 1.3.72 as well
👍 1
w

wasyl

08/13/2020, 7:05 PM
We’ll give it a go, thanks a lot!
s

sam

08/13/2020, 7:05 PM
Let me know as I'm releasing 4.2.0.RC2 today and 4.2.0 on Monday
So any issues I'll get them fixed asap
👍 1
w

wasyl

08/13/2020, 7:08 PM
That means Kotlin 1.4 goes out on Monday? 😄