https://kotlinlang.org logo
Title
b

bbaldino

05/21/2020, 5:29 AM
I found myself wanting a coroutine-friendly
shouldTimeout
and wrote one for kotest which seems to work, would there be interest in a PR? Or is there a way of doing this that I missed?
s

sam

05/21/2020, 1:02 PM
You can add a timeout directly to a test but this would be great for finer grained control in tests. Please do pr !
b

bbaldino

05/21/2020, 4:08 PM
@LeoColman re: https://github.com/kotest/kotest/pull/1448 where should the tests go? It wasn't obvious to me, but I haven't worked on a multiplatform project before, so the layout is a bit unfamiliar
l

LeoColman

05/21/2020, 10:08 PM
kotest-assertions-core/jvmTest
b

bbaldino

05/21/2020, 10:08 PM
ok, thanks, guess there just weren't any tests for the existing methods there
l

LeoColman

05/21/2020, 10:08 PM
That can happen 😅
s

sam

05/21/2020, 10:20 PM
Can we move shouldTimeout to assertion-shared though
There's no reason to require the assertions library to use it.
The test can stay wherever
b

bbaldino

05/21/2020, 10:20 PM
Sure
What package?
s

sam

05/21/2020, 10:21 PM
whatever you think is best
b

bbaldino

05/21/2020, 10:22 PM
Within
io.kotest.assertions
there, though?
s

sam

05/21/2020, 10:23 PM
yeah perfect
b

bbaldino

05/21/2020, 11:23 PM
Anything special I need to do in intellij to load the gradle correctly? I run into:
Cause: java.lang.UnsupportedOperationException
	at java.base/java.util.Collections$1.remove(Collections.java:4714)
	at java.base/java.util.AbstractSet.removeAll(AbstractSet.java:176)
	at org.jetbrains.plugins.gradle.service.project.GradleProjectResolverUtil.doBuildDependencies(GradleProjectResolverUtil.java:646)
	at org.jetbrains.plugins.gradle.service.project.GradleProjectResolverUtil.buildDependencies(GradleProjectResolverUtil.java:565)
	at org.jetbrains.kotlin.idea.configuration.KotlinMPPGradleProjectResolver$Companion$populateModuleDependencies$1.invoke(KotlinMPPGradleProjectResolver.kt:543)
	at org.jetbrains.kotlin.idea.configuration.KotlinMPPGradleProjectResolver$Companion$populateModuleDependencies$1.invoke(KotlinMPPGradleProjectResolver.kt:185)
	at org.jetbrains.kotlin.idea.configuration.KotlinMPPGradleProjectResolver$Companion.processCompilations(KotlinMPPGradleProjectResolver.kt:799)
	at org.jetbrains.kotlin.idea.configuration.KotlinMPPGradleProjectResolver$Companion.populateModuleDependencies(KotlinMPPGradleProjectResolver.kt:539)
	at org.jetbrains.kotlin.idea.configuration.KotlinMPPGradleProjectResolver.populateModuleDependencies(KotlinMPPGradleProjectResolver.kt:153)
   ...
when trying to load it
s

sam

05/21/2020, 11:24 PM
That's because intellij 2020 doesn't work with MPP projects properly
it's a known bug affecting any MPP project with > 1 module
b

bbaldino

05/21/2020, 11:24 PM
Well fudge.
s

sam

05/21/2020, 11:24 PM
and its really really annoying for anyone who wants to hack on kotest
I have intellij installed twice
b

bbaldino

05/21/2020, 11:25 PM
Looks like I happen to have an old CE installed, so I'll try that.