Hi, not sure if this a question for this channel o...
# touchlab-toolsr
Rak
10/20/2021, 8:24 AMHi, not sure if this a question for this channel or Koin but going through the code, I noticed that constructor injection is NOT used and instead by inject and inheriting from KoinComponent. Is there a reason for this? I have always tried to restrict the use of framework classes in my code and in my other (non KMM) projects, Koin was used via constructor injection
r
russhwolf
10/21/2021, 12:11 AMThat’s actually something I’ve been wanting to refactor at some point. We use constructor injection in most places, just not in BreedModel
r
Rak
10/21/2021, 12:14 PMWould you accept a PR?
r
russhwolf
10/21/2021, 1:12 PMIn theory yes, but we've been talking about some other refactors in the viewmodel architecture and there's some chance that would conflict with whatever change you make.
r
Rak
10/21/2021, 1:23 PMOK, let me know if you want any help.
3 Views