https://kotlinlang.org logo
Title
m

MarkRS

09/30/2021, 1:15 PM
Quiet in here, eh? 🙂 Do yous guys use Intellij? I ask because (I'm using AS, and) I notice your gradle wrapper file specifies gradle-7.1-all.zip , which seems to work on AS, but then again it's just asked me if I want to upgrade from 7.0.1.... which seems odd.
r

russhwolf

09/30/2021, 1:49 PM
We have mixture. I tend to prefer Intellij, but KaMPKit currently requires Android Studio because it needs AGP 7.x for Compose. But that's different from gradle wrapper version so I'm not sure exactly what you're seeing.
m

MarkRS

09/30/2021, 4:33 PM
The Android docs seem to say that the latest version is 7.0.2. I tried using 7.1 (incorrectly, as it turns out), but then saw the suggestion to upgrade, which was my confusion. Your new versioning code looks pretty impenetrable. How do you know what version is actually being used? Is there a 7.1 or is it falling back to 7.0.1
r

russhwolf

09/30/2021, 4:38 PM
Don't mix up the Gradle version with the Android Gradle Plugin version. The one in
gradle-wrapper.properties
is the Gradle version which is set to 7.1. The Android Gradle Plugin version for the project is defined as 7.0.1 here: https://github.com/touchlab/KaMPKit/blob/main/gradle/libs.versions.toml#L36
m

MarkRS

09/30/2021, 4:40 PM
Ah, thank you. I'd seen that file but not realised its significance. Is this new strategy to avoid using buildsrc, which is said to be very slow?
r

russhwolf

09/30/2021, 4:53 PM
m

MarkRS

09/30/2021, 5:07 PM
Interesting, thanks. Does AS's lint check these versions better than the buildSrc route (which doesn't check at all)?
Hmm, perhaps the answer to that is an obvious "no", since it was AS that suggested I update and there was no indication (I could easily see) in the KampKit code 😞
r

russhwolf

09/30/2021, 5:11 PM
Yeah I don't think AS knows its way around that file yet