https://kotlinlang.org logo
Title
f

Friedger

06/10/2020, 8:40 PM
I looked a bit into the code, here is what I found could work with kotlinx.serialization: https://github.com/Yelp/swagger-gradle-codegen/pull/136 I understand that this work is not finished before the polymorphism logic is ready.
@gammax I am struggling to get klint pass for my PR
g

gammax

06/12/2020, 6:31 PM
Do you have an error message to share?
f

Friedger

06/12/2020, 6:31 PM
I thought that locally klint passed but then the ci complained
After I runHooks and commit the changes, then klint should pass, shouldn't it?
g

gammax

06/12/2020, 6:33 PM
Can you run
./gradlew preMerge
?
f

Friedger

06/12/2020, 6:33 PM
no, just runHooks
I'll try that
g

gammax

06/12/2020, 6:34 PM
Yeah run hooks will run the pre-commit hooks but only on your index.
preMerge
is what the CI is running. It re-runs ktlint on the whole codebase.
So what could have happened is that you committed some code in the past that is invalid, and pre-commits are running only on your latest change.