Zac Sweers
09/25/2021, 8:00 PMyigit
09/25/2021, 8:14 PMZac Sweers
09/25/2021, 8:21 PMTing-Yuan Huang
09/25/2021, 11:06 PMFudge
09/26/2021, 11:26 AM1.0.0+1.5.31
, 1.0.0-RC+1.5.31
? This syntax is common when your library version is dependant on the platform's version.Zac Sweers
09/26/2021, 5:19 PMTing-Yuan Huang
09/27/2021, 11:27 PMZac Sweers
09/28/2021, 3:42 PMVersionNumber
in gradle maybe?Ting-Yuan Huang
10/06/2021, 6:55 PM2.0.0
for the next release, instead of 1.6.0-1.0.1
. We tried a range of versioning schemes and tested with Gradle's VersionNumber
, and it seems to be the best option.
Here are some examples that we tried and they didn't work (return false):
VersionNumber.parse("1.6.0-1.0.1") > VersionNumber.parse("1.6.0-1.0.1-RC")
VersionNumber.parse("1.6.0-1.0.1") > VersionNumber.parse("1.6.0-RC-1.0.1")
VersionNumber.parse("2.0.0+1.6.0") > VersionNumber.parse("2.0.0-RC+1.6.0")
VersionNumber.parse("2.0.0+1.6.0") > VersionNumber.parse("2.0.0+1.6.0-RC")
Note that the 2.0.0
release doesn't change that much; It's bumped so that it is greater than the Kotlin version prefix (1.5.31) we have currently.Zac Sweers
10/06/2021, 7:24 PM2.0.0
? Or 1.6.0-2.0.0
?Ting-Yuan Huang
10/06/2021, 8:13 PM2.0.0
. It'd confuse Gradle with more than 4 parts in the version.
https://github.com/gradle/gradle/blob/master/subprojects/core/src/main/java/org/gradle/util/VersionNumber.javaZac Sweers
10/06/2021, 8:14 PMTing-Yuan Huang
10/06/2021, 8:16 PM2.0.0-M1
is the better choice among other options. 🤷Zac Sweers
10/06/2021, 8:17 PMTing-Yuan Huang
10/06/2021, 8:20 PMZac Sweers
10/07/2021, 4:32 AMTing-Yuan Huang
10/07/2021, 4:33 AMglureau
10/07/2021, 6:20 AMZac Sweers
10/07/2021, 2:52 PM