<@U014HUWN7B5> You brought up non-JVM support for ...
# ksp
a
@Ting-Yuan Huang You brought up non-JVM support for the PR I submitted. I thought it might be useful to discuss ideas about the non-JVM support for https://github.com/google/ksp/pull/508 which adds the getAnnotationsByType and isAnnotationPresent experimental methods. I saw that the latest version of Kotlin 1.5.30 provides the ability to instantiate. I am not sure if this provides a better integration into just utilizing Kotlin reflection and isolating away from using JVM specific calls. This KEEP discusses “3. Better multiplatform support”. What are your thoughts, as I am just scratching the surface of the JVM vs Multiplatform understanding here.
t
Thanks for noticing the language update. My understanding is that it is defined and implemented for JVM at the moment. Other platforms are TBD. Nevertheless, it is very promising for multiplatform and I believe that in the future it will become clear on the behaviors that we discussed in the PR. So instead of sticking with JVM by requiring
java.lang.Class
, we should be able to count on
KClass
as it seems more future-proof. I'm sorry but could we switch back to
KClass
for the parameter type in the PR?
a
yes absolutely, let’s do that, as it makes more sense with the latest news
🙏 1
Hey @Ting-Yuan Huang I saw the release included the PR https://github.com/google/ksp/pull/508 , but it wasn’t in the release notes. Just wanted to know if that was intentional or if it was just missed.
t
I think we just missed it in the release note. I'm really sorry. I'll update the release note.
a
no worries, I figured it was an oversight, was just talking about it with a friend and noticed it
thanks @Ting-Yuan Huang
t
My apology for missing it. I've updated the release note and put it in the hightlights.
a
no worries, appreciate you updating it
t
BTW, I think we should have placed it in the API jar rather than the compiler plugin jar, which is implementation. I've moved it in https://github.com/google/ksp/pull/610. The package name is changed. Please let me know if any concerns.
a
ah that makes sense, should have done that
t
Thanks. Actually I added an API in there as well 😛 and moved it in the same commit.
a
glad I could help 😉