Hi I have a question why

Question

Hi I have a question why <https github com google ksp blob 9f8d05b1af44857bc6de926d9be49e74b2c4a107 compiler plugin src main kotlin com google devtools ksp symbol impl kotlin KSNameImpl kt L24|KSNameImpl> doesn t override equals method Wouldn t it be easier to write this `it simpleName == shortName` instead of this `it simpleName asString == shortName asString ` Before looking into the impl I even thought that calling `asString ` is not efficient because conversion from some inner representation to String might happen

yigit · Answer

it probably should that being said the ones created by KSP always give you the same instance <https github com google ksp blob 9f8d05b1af44857bc6de926d9be49e74b2c4a107 compiler plugin src main kotlin com google devtools ksp symbol impl kotlin KSNameImpl kt L26|https github com google ksp blob 9f8d05b1af44857bc6de926d9be49e74b2c4a107 compil kotlin com google devtools ksp symbol impl kotlin KSNameImpl kt>

yigit · Answer

so even `===` would work

Anton Popov · Answer

it is good but i can t rely on this behaviour as it can change

Anton Popov · Answer

thanks

Ting-Yuan Huang · Answer

Yep currently the equivalence is done through the cache If we moved away from that implementation we ll implement equals if needed

yigit · Answer

i think we should implement equals no wouldn t that help if someone else implements KSName in their processor Idk why people would do that but we have a couple of places in room where we implement those interfaces

Ting-Yuan Huang · Answer

That s a good point Honestly there are some other places expecting specific implementation like KSTypeImpl We didn t take the interaction with user implementation into consideration

Ting-Yuan Huang · Answer

On the other hand that use case is probably quite rare while making the implementation more complicated and less efficient in general Unless there is a real example I m leaning against the complexity for the hypothetical cases

yigit · Answer

yea i don t mean KSp should accept user implemented interfaces But i don t think implementing equals adds any complexity to KSP

Ting-Yuan Huang · Answer

No it doesn t add complexity in this case If users need it I m happy to implement it

Anton Popov · Answer

It would also be nice if in KDocs of KSName was stated that users can rely on calling equals as it is implemented and guaranteed to work properly

Ting-Yuan Huang · Answer

Sure will update the doc