Hi! I have a question: why <KSNameImpl> doesn't override equals method? Wouldn't it be easier to wri...

# ksp

[Anton Popov]

Hi! I have a question: why KSNameImpl doesn't override equals method? Wouldn't it be easier to write this it.simpleName == shortName instead of this it.simpleName.asString() == shortName.asString(). Before looking into the impl, I even thought that calling asString() is not efficient, because conversion from some inner representation to String might happen.

[yigit]

it probably should. that being said, the ones created by KSP always give you the same instance:

https://github.com/google/ksp/blob/9f8d05b1af44857bc6de926d9be49e74b2c4a107/compil[…]kotlin/com/google/devtools/ksp/symbol/impl/kotlin/KSNameImpl.kt

[yigit]

so even === would work

[Anton Popov]

it is good, but i can't rely on this behaviour, as it can change (

[Anton Popov]

thanks!

[Ting-Yuan Huang]

Yep, currently the equivalence is done through the cache. If we moved away from that implementation, we'll implement equals if needed.

[yigit]

i think we should implement equals no? wouldn't that help if someone else implements KSName in their processor.

Idk why people would do that but we have a couple of places in room where we implement those interfaces

[Ting-Yuan Huang]

That's a good point. Honestly there are some other places expecting specific implementation like KSTypeImpl. We didn't take the interaction with user implementation into consideration.

[Ting-Yuan Huang]

On the other hand, that use case is probably quite rare while making the implementation more complicated and less efficient in general. Unless there is a real example, I'm leaning against the complexity for the hypothetical cases.

[yigit]

yea i don't mean KSp should accept user implemented interfaces. But i don't think implementing equals adds any complexity to KSP

[Ting-Yuan Huang]

No, it doesn't add complexity in this case. If users need it, I'm happy to implement it.

[Anton Popov]

It would also be nice if in KDocs of KSName was stated, that users can rely on calling equals, as it is implemented and guaranteed to work properly

[Ting-Yuan Huang]

Sure, will update the doc.