https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
j

Jiaxiang

05/12/2021, 11:59 PM
Hi, here is the latest KSP release. Please note that we are pretty close to beta stage. In beta stage we want to avoid making API changes, if you have any changes you want to see in terms APIs, now is still a good time. This release is a pretty long one, please refer to the release note on Github for full list of changes in this release. Major breaking changes: • switch to 
Sequence
 for a bunch of APIs ◦ Some of the API return type has been changed from 
Collection
 or 
List
 to 
Sequence
, which will allow performance improvement if you use case involved early termination. ◦ Note that because 
Sequence
 is lazily evaluated, it requires a terminal operation to make actual compute happen. Please check you uses around the impacted APIs to see if they have a terminal operation. Most common use case is 
Collection.map{}
 which will iterate through the collection by itself, but is non-terminal for 
Sequence
 and should be companied with 
toList()
 or replaced with 
forEach
◦ For the whole list of APIs impacted by this change, please refer to this commit. • Origin for KS symbols from binaries is now split into 
KOTLIN_LIB
 and 
JAVA_LIB
.
🎉 2
👍 5
👍🏼 1
y

yigit

05/13/2021, 12:01 AM
One api i have on my mind if the ability to check if a property has a backing field. I've been meaning to add it but didn't have much time these days
👍 1
j

Jiaxiang

05/13/2021, 12:02 AM
I can add an issue for that
y

yigit

05/18/2021, 12:50 AM
i started working on this
so this turned out a lot more complicated then a function call to an existing descriptor API 😕 https://github.com/yigit/ksp/commit/9f7d348a76fc6e2ddae8695ecfddff6a0e50cb0d resolveUtil in compioler has a weird logic with a TODO. https://github.com/JetBrains/kotlin/blame/master/compiler/frontend/src/org/jetbrains/kotlin/resolve/resolveUtil.kt Then there are workarounds i found in the source code but they are still not detecting properties w/o backing fields properly when the property is in a descriptor. https://github.com/yigit/ksp/commit/9f7d348a76fc6e2ddae8695ecfddff6a0e50cb0d#diff-675bc4d99ebd3438e286a65973c3b[…]31d6ad272d42b3181a916a0655c347R431 will need to debug further.
t

Ting-Yuan Huang

05/18/2021, 9:48 PM
In
resolveUtil.kt
,
getter != null -> false
looks weird to me; A backing field can be used in a getter, right?
for example,
fun foo() = 1
val x: Int = foo()
    get() = field
fails the
hasBackingField
For source code, I think a property has a backing field if and only if it has a initializer. For library,
DeserializedPropertyDescriptor
is created with backingField always set; The information is lost.
OTOH, in Kotlin, a backing field is kind of private implementation of a property. Accessing it outside of accessors might be a little bit weird.
y

yigit

05/18/2021, 11:29 PM
For room, we need to know to decide whether that property should be saved into a database column or not. While searching usages of the internal api on kotline source code, i noticed kotline serialization does the same
maybe it works good enough for serialization of they only support src code and not binary dependencies
t

Ting-Yuan Huang

05/19/2021, 1:39 AM
I'm trying to see if there's some way to infer the backing field but so far haven't found anything
It basically tries to see if there is a field with the same name to the property in the binary class.
y

yigit

05/19/2021, 3:00 AM
That seems feasible to me. Just a minor change is needed to get the jvm name i guess but i can take it from your patch. Meanwhile, we should probably double check with JB on why that method does not really work
👍 1
ok that passes the test. i'll try to add more with jvm name, overrides etc
oh nice, JVM name doess not affect because the class visitor always gives kotlin names 🙂 i'll still keep the test cases
oh that is because i was using JvmField not jvm name 🤦‍♂️ also, jvm name is not applicable to fields it is only applicable to methods https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.jvm/-jvm-name/
t

Ting-Yuan Huang

05/24/2021, 5:28 PM
Not having to consider jvm name sounds a great relief :-) As for override / inheritance, since the API is on KSPropertyDeclaration, which is always the place where it is defined, we probably don't need to check overridden property?
y

yigit

05/24/2021, 5:29 PM
thats what i'm trying to figure out but the API in kotlin compiler looks for overrides, though only when it is fake:
fun PropertyDescriptor.hasBackingField(bindingContext: BindingContext?): Boolean = when {
    kind == CallableMemberDescriptor.Kind.FAKE_OVERRIDE -> overriddenDescriptors.any { it.hasBackingField(bindingContext) }
t

Ting-Yuan Huang

05/24/2021, 5:32 PM
That doesn't seem to applicable in our case, or we have something to fix in getAllProperties
y

yigit

05/24/2021, 5:33 PM
yea i think we don't return them
👍 1
sent an initial PR. One test case i could create is to create a java method pair that looks like a property. For some reason, it does not show up when traversing properties https://github.com/google/ksp/pull/449/files#diff-f8c01fc500f3df4198742e0508c930581723f430d30bb308aed2316a6c3c67f0R162 Need to check, i forgot if KSP converts them to properties or not