Jiaxiang
05/08/2021, 12:26 AMCollection
to Sequence
for a better performance. This change will need your attention as Sequence
is lazily evaluated and requires a terminal operation to make it actually compute. Here is my API change, please kindly take a look and leave comments in case of any concerns. The most important item I want to hear from you is if your use case involves some operations that is not feasible with a sequence, like indexed access operation which is only possible on a List (while you can still call .toList()
on a sequence to do that, if this becomes a common use case, it might make more sense to just make it List
)evant
05/08/2021, 12:36 AMJiaxiang
05/08/2021, 12:39 AMList
evant
05/08/2021, 12:44 AMJiaxiang
05/08/2021, 12:52 AMtypeParameter
s, `typeArgument`s, general argument
s and function `parameter`s to be simply List
evant
05/08/2021, 12:55 AMelihart
05/08/2021, 5:46 PMJiaxiang
05/10/2021, 10:28 PMList
, therefore it is better to keep them List
. Furthermore, in our implementations, most of these arguments and parameters are just a wrapper of underlying data structure so not heavy work involved, performance wise is not very significant.elihart
05/11/2021, 3:04 AM