Zac Sweers
12/24/2020, 12:40 AMdependOnNewChanges
would be false?Ting-Yuan Huang
12/24/2020, 12:44 AMZac Sweers
12/24/2020, 12:45 AMTing-Yuan Huang
12/24/2020, 12:48 AMZac Sweers
12/24/2020, 12:49 AMTing-Yuan Huang
12/24/2020, 12:51 AMdependsOnNewCHanges
means new files or changes in other files.Zac Sweers
12/24/2020, 12:52 AMTing-Yuan Huang
12/24/2020, 12:52 AMdependsOnNewFiles
?Zac Sweers
12/24/2020, 12:52 AMTing-Yuan Huang
12/24/2020, 12:56 AMdependOnNewFiles
, it and its inputs has a chance to be skipped. Any outputs depending on new files will cause their inputs to be marked as dirty.Zac Sweers
12/24/2020, 12:56 AMfalse
in most cases?Ting-Yuan Huang
12/24/2020, 12:58 AMZac Sweers
12/24/2020, 1:01 AMTing-Yuan Huang
12/24/2020, 1:02 AMZac Sweers
12/24/2020, 1:03 AMTing-Yuan Huang
12/24/2020, 1:03 AMZac Sweers
12/24/2020, 1:04 AMTing-Yuan Huang
12/24/2020, 1:06 AMdependsOnNewFiles
should be included, because newly added files or changes in some other existing files may cause them to be included in the future.dependsOnNewFiles
can be thought of a wildcard, referencing new files or changes in all existing files.Zac Sweers
12/24/2020, 1:08 AMTing-Yuan Huang
12/24/2020, 1:10 AMdependsOnNewFiles
won't affect the propagation of dirtyness due to new files. Let me try to build an example.dependsOnNewFiles
to aggregating/isolating
. It is the same idea as in java, but the scope is per-output rather than entire processor. What do you think?Zac Sweers
12/24/2020, 1:46 AMTing-Yuan Huang
12/24/2020, 1:46 AMZac Sweers
12/24/2020, 1:47 AM@JsonClass(generateAdapter = true)
Message.kt with class Message
results in MessageJsonAdapter
generated
later two other files are added. One with another json class and another with something unrelated.
How does that example fit?Ting-Yuan Huang
12/24/2020, 1:52 AMdependsOnNewChanges
should be false
in this case, because each existing output doesn't depend on new information.Zac Sweers
12/24/2020, 1:52 AMTing-Yuan Huang
12/24/2020, 1:54 AMdependsOnNewChang = true
for that relevant outputs.Zac Sweers
12/24/2020, 1:54 AMaggregating
?Ting-Yuan Huang
12/24/2020, 1:56 AMdependsOnNewChanges
to isAggregating
Zac Sweers
12/24/2020, 1:57 AMTing-Yuan Huang
12/24/2020, 1:57 AMaggregating
Zac Sweers
12/24/2020, 1:58 AM