FYI if upgrading to newest Canary 13 while using D...

# mvikotlin

[JimK]

FYI if upgrading to newest Canary 13 while using Decompose the mpp/compose workaround needs to be updated to reflect the new compose compiler location refactor:

project.dependencies {
        composeCompiler "androidx.compose.compiler:compiler:$compose_version"
    }

[JimK]

there are "phi errors" in the build for material packages that I can't make heads or tails of though

[Arkadii Ivanov]

So does it work?

[JimK]

I haven't noticed any issues just yet

[JimK]

it's specifically referencing viewPager jar that I'm not using in the app

[Arkadii Ivanov]

You mentioned "phi errors", looks like not so important?

[JimK]

they presented as warnings in the build but the text said "Phi error with register 6" or "register 37". The warnings have not shown up after the first build. All tests have passed and the app is working as expected

[JimK]

I have decompose pulled, let me see if I can get the errors on the todo sample

[JimK]

this is the warning

[Arkadii Ivanov]

Ok, looks like just warnings

[Arkadii Ivanov]

Thanks! Would you mind submitting a PR with the update?

[JimK]

Absolutely, will do

[Arkadii Ivanov]

Thanks!

[JimK]

Those warnings must mean something, the Modifier.weight function isn't recognized

[JimK]

I don't see anything in release notes and it's marked as @Stable

[Arkadii Ivanov]

Worth to ask in their channel. Heard that the new alpha is buggy.

[JimK]

It was new implementation detail for ColumnScope / RowScope modifiers to avoid them being used where they'll be ignored

[JimK]

those modifiers need to be used within with(ColumnScope){ Modifier.weight() }

[Arkadii Ivanov]

Nice catch!

[JimK]

How can I open a PR on the project, I'm used to enterprise where I can push up a branch

[Arkadii Ivanov]

Basically you need to fork the repo, clone it to your local machine and add upstream remote. Then create a branch, commit and push to your repo. Then you will see a button if you open the original repo.

[JimK]

Thank you

[Arkadii Ivanov]

https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork